Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add twisted errors to list of Fido timeouts #346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

Add twisted errors to list of Fido timeouts #346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion bravado/fido_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import requests
import requests.structures
import six
import twisted
from bravado_core.response import IncomingResponse
from yelp_bytes import to_bytes

Expand Down Expand Up @@ -171,7 +172,9 @@ class FidoFutureAdapter(FutureAdapter):
retrieve results.
"""

timeout_errors = [fido.exceptions.HTTPTimeoutError]
timeout_errors = (fido.exceptions.HTTPTimeoutError,
twisted.internet.error.DNSLookupError,
twisted.internet.error.ConnectingCancelledError,)

def __init__(self, eventual_result):
self._eventual_result = eventual_result
Expand Down