Add twisted errors to list of Fido timeouts #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ConnectingCancelledError to the list of Fido timeouts
|
@bplotnick sorry for the late reply |
|
@macisamuele Yeah I am not too happy with this either because the errors could probably be caused by other issues. However, I'm not entirely sure what the alternative is. Could we put some sort of "reasonable" minimum timeout? Is that going to be reliable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #344 by adding twisted.internet.error.DNSLookupError and twisted.internet.error.ConnectingCancelledError to the list of timeout errors.
As mentioned in the issues, these seem like more general than just timeouts, but I can reliably reproduce them by setting low request timeouts, so they should probably be caught somehow.