Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PC-270] 매칭 조각 확인 기능 구현 #30
base: feature/PC-268-matching-algorithm
Are you sure you want to change the base?
[PC-270] 매칭 조각 확인 기능 구현 #30
Changes from all commits
57cd332
1c8b517
a3a2978
1110bfd
92a3759
8157d74
4a35f24
d321a3f
252150c
48b715c
0ae130d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url 하나만 Response 객체로 만든 이유가 있으실까요 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
json 형식으로 반환하는것이 PlainText로 반환하는 것보다 클라이언트가 사용할 때 편리할 것이라고 생각해서 Response 객체를 만들었습니다.
Map보다는 Response 객체를 만드는 것이 코드 통일성면이나 이후 확장성면에서 좋다고 생각합니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저는 Response 객체는 record를 사용했는데, 통일성을 위해 record를 사용하는 것은 어떨까요 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋은 것 같습니다!
PR이 쌓여있어서...충돌이 날 것 같으니 다음 PR에 record로 전부 수정해놓겠습니다!