[PC-270] 매칭 조각 확인 기능 구현 #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lujaec
reviewed
Jan 22, 2025
|
|
||
| @NoArgsConstructor | ||
| @Getter | ||
| @AllArgsConstructor |
There was a problem hiding this comment.
저는 Response 객체는 record를 사용했는데, 통일성을 위해 record를 사용하는 것은 어떨까요 ?
There was a problem hiding this comment.
좋은 것 같습니다!
PR이 쌓여있어서...충돌이 날 것 같으니 다음 PR에 record로 전부 수정해놓겠습니다!
| import lombok.Getter; | ||
| import lombok.NoArgsConstructor; | ||
|
|
||
| @Getter |
There was a problem hiding this comment.
url 하나만 Response 객체로 만든 이유가 있으실까요 ?
There was a problem hiding this comment.
json 형식으로 반환하는것이 PlainText로 반환하는 것보다 클라이언트가 사용할 때 편리할 것이라고 생각해서 Response 객체를 만들었습니다.
Map보다는 Response 객체를 만드는 것이 코드 통일성면이나 이후 확장성면에서 좋다고 생각합니다.
| @@ -54,4 +53,12 @@ public MatchInfo(LocalDate date, User user1, User user2) { | |||
| public static MatchInfo createMatchInfo(User user1, User user2) { | |||
| return new MatchInfo(LocalDate.now(), user1, user2); | |||
| } | |||
|
|
|||
| public void checkPiece(Long userId) { | |||
There was a problem hiding this comment.
파라미터로 user1과 user2 id 만 보장이 있는 것은 아닌거 같은데. else로 처리하게 되면 문제가 생길 수 있을 것 같습니다.
There was a problem hiding this comment.
getMatchInfo를 통해 얻은 MatchInfo는 반드시 user1또는 user2만 있기 때문에 그렇게 구현을 했는데, 생각해보니 캡슐화를 지키지 못한 구현이었네요! 수정하겠습니다.
api/src/main/java/org/yapp/domain/match/presentation/MatchController.java
Show resolved
Hide resolved
devchlee12
changed the base branch from
develope
to
feature/PC-268-matching-algorithm
Lujaec
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
PC-270
✨ 작업 내용
✅ 체크리스트
🎃 새롭게 알게된 사항
📋 참고 사항