Checking extra packages upload-1 #268

* patch fix for checkout in GHA * fixing the checkout for windows too

* CR-1183009 Fix mem-bw and verify bugs in validate * CR-1183009 Fix kernel run waiting, revert iterations * CR-1183009 Fix verify to check for hello kernel in absence of platform.json * CR-1183009 Fix Windows comiple error * CR-1183009 Check for hello in verify.xclbin for IOPS test * CR-1183009 Use krnl.name for hello kernel

Co-authored-by: ch vamshi krishna <[email protected]>

#1) (Xilinx#7835) Problem solved by the commit Enabled setting XRT install prefix to custom location on Linux build. Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered Xilinx#6783 How problem was solved, alternative solutions (if any) and why they were rejected Modified corresponding CMake files, Makefiles and build scripts. Risks (if any) associated the changes in the commit Low What has been tested and how, request additional testing if necessary Built XRT on Ubuntu 22.04. Documentation impact (if any) NA Signed-off-by: Chiming Zhang <[email protected]>

…#7836) * [NFC] Remove random TAB and spaces This file would require a serious beautifier. Signed-off-by: Ronan Keryell <[email protected]> * Add missing apt-get update to have an up-to-date package list Signed-off-by: Ronan Keryell <[email protected]> --------- Signed-off-by: Ronan Keryell <[email protected]>

…7847) * Fix-CR-1183009 Use py test when there is no platform.json for mem-bw * Fix-CR-1183009 Remove duplicate busybar from runScript

* Fixing XRT issue for Ubuntu 23.10 Signed-off-by: Homa Aghilinasab <[email protected]> * Fixing XRT issue for Ubuntu 23.10 Signed-off-by: Homa Aghilinasab <[email protected]> * Fixing XRT issue for Ubuntu 23.10 Signed-off-by: Homa Aghilinasab <[email protected]> * Fixing XRT issue for Ubuntu 23.10 Signed-off-by: Homa Aghilinasab <[email protected]> --------- Signed-off-by: Homa Aghilinasab <[email protected]>

…x#7852)

…ilinx#7855) Adjust copying of wchar[] array into std::wstring accounting for bytes vs wchar. Code queries windows adpater for driver store path. The driver store path is returned as array of wchar but was copied as bytes, resulting in copying from unallocated memory. This bug was introduced in Xilinx#7679 and is present in MCDM drops starting M6. Signed-off-by: Soren Soe <[email protected]>

Signed-off-by: Manoj Takasi <[email protected]>

…7857) * Skeleton directory and build infrastructure for HIP bindings Very preliminary infra for HIP bindings. Build on linux with `build.sh -hip [other options]` Signed-off-by: Soren Soe <[email protected]> * Review comments --------- Signed-off-by: Soren Soe <[email protected]>

…nx#7856) * VITIS-10910 Separate ryzen and alveo device lists within ReportHost Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-10910 Separate json generation for ryzen cards for host report Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-10910 Fix indentation Signed-off-by: Daniel Benusovich <[email protected]> --------- Signed-off-by: Daniel Benusovich <[email protected]>

Signed-off-by: Quentin Berthet <[email protected]> Co-authored-by: Quentin Berthet <[email protected]>

…inux9 (Xilinx#7861) * Update the dependency installation script to work on almalinux9 Signed-off-by: Quentin Berthet <[email protected]> * Allow to build and package on AlmaLinux9 Signed-off-by: Quentin Berthet <[email protected]> --------- Signed-off-by: Quentin Berthet <[email protected]> Co-authored-by: Quentin Berthet <[email protected]>

…present (Xilinx#7862) Signed-off-by: Daniel Benusovich <[email protected]>

Fix regression introduced in Xilinx#7177. Make sure non-trivially destructible static global objects, that act as a cache, are not accessed during static global destruction. If application code keep global XRT device objects, then these can end up accessing non-trivially destructible objects during static global destruction. Keep a terminal trivially destructible static global (a POD type object) that is destructed prior to the non-trivially ones. Test the POD type object before accessing the complex globals. Better to redesign and remove the need for these static global cache objects, but that has to other implications. Signed-off-by: Soren Soe <[email protected]>

* Workaround for cpack failure on Ubuntu 23.10 * cpack workaround is only for Ubuntu 23.10 * DCO Remediation Commit for Sonal Santan <[email protected]> I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: 3863648 I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: eed3e30 Signed-off-by: Sonal Santan <[email protected]> --------- Signed-off-by: Sonal Santan <[email protected]>

* Initial changes for removal of xcl apis Signed-off-by: rbramand <[email protected]> * Fix build failure Signed-off-by: rbramand <[email protected]> * Fix review comments Signed-off-by: rbramand <[email protected]> --------- Signed-off-by: rbramand <[email protected]> Co-authored-by: rbramand <[email protected]>

Signed-off-by: Manoj Takasi <[email protected]>

…tall (Xilinx#7867) * Add upstream HIP as submodule to get header file definitions * A simple vadd example for hip * Added support for installing hip-dev -- which provides the official HIP header files -- from the Linux distribution * Updated build infra to use HIP header files from HIP install area * Add comment about defining __HIP_PLATFORM_AMD__ * Drop installation of hip.h file * Minor code adjustments Signed-off-by: Sonal Santan <[email protected]> * DCO Remediation Commit for Sonal Santan <[email protected]> I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: a91d26b I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: d384c9f I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: 5076b02 I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: a394207 I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: ab75f5c I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: 18de09c Signed-off-by: Sonal Santan <[email protected]> * Improve the cmake handling of HIP for XRT to reduce warning messages Enable building of HIP tests for XRT along with xrt and unit_test * Remove redundant directory for vadd * Code updates to address style issues Add CMake based build of hip testcases Signed-off-by: Sonal Santan <[email protected]> * DCO Remediation Commit for Sonal Santan <[email protected]> I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: 747b2f3 I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: dc9eabf Signed-off-by: Sonal Santan <[email protected]> * Drop usage of boost in hip testcases Signed-off-by: Sonal Santan <[email protected]> * Change the PASS/FAIL string to XRT standard Signed-off-by: Sonal Santan <[email protected]> --------- Signed-off-by: Sonal Santan <[email protected]>

Signed-off-by: Manoj Takasi <[email protected]>

* Script to enable building of tests directory in CI Signed-off-by: Sonal Santan <[email protected]> * Script to enable building of tests directory in CI Signed-off-by: Sonal Santan <[email protected]> --------- Signed-off-by: Sonal Santan <[email protected]>

…Xilinx#7875) Share the ownership of xrt_core::hwqueue_handle with shim. A hwqueue is managed by hwctx (today 1:1), and used by coreutil XRT (coreutil) for submitting commands for execution and more. XRT shim may itself use the hwqueue for miscellaneous commands and as such the underlying queue is actually owned by shim (hwctx_handle) but shared with coreutil. This PR makes it explicit that the hwqueue ownership is with the hwctx_handle. XRT coreutil no longer creates a hwqueue but instead gets a hwqueue_handle from the hwctx_handle. Prior to this change, there were strange hacks at shim level to return a unique_ptr to something that is actually shared. This strange logic can now be changed. It is the responsibility of XRT coreutil to ensure that lifetime of a hwctx extends the use of the hwqueue_handle that was obtained from the hwctx_handle. Signed-off-by: Soren Soe <[email protected]>

* Refactor XRT to cache created devices Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11043 Add export for report functions Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11043 Fix comment headers Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11043 Return mgmt device when requested instead of user device Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11043 Convert map to vector for device caching. Add mutex to protect device initialization. Signed-off-by: Daniel Benusovich <[email protected]> --------- Signed-off-by: Daniel Benusovich <[email protected]>

* VITIS-10999 Improve electrical report output Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-10999 Add maximum power extraction for power sensor. Add logic to convert units for power sensor. Signed-off-by: Daniel Benusovich <[email protected]> --------- Signed-off-by: Daniel Benusovich <[email protected]>

* VITIS-10866 - Patching instruction buffer in XRT * VITIS-10866 - respond to comments * VITIS-10086 Add comments about patching schemes --------- Co-authored-by: dezhliao <[email protected]>

* added authorize job and few secrets under build and apu package * Create xrt-pr-comment-ci.yaml * adding edit permission for .github/workflows/ * adding authorizers list * updated checkout * using access_token for authorize * env updated to prod * adding ref: main * adding ref: main

…ilinx#7879) * VITIS-11094 Remove device ID and device readiness for Ryzen devices Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11094 Update comment header Signed-off-by: Daniel Benusovich <[email protected]> --------- Signed-off-by: Daniel Benusovich <[email protected]>

Signed-off-by: Daniel Benusovich <[email protected]>

…in ryzen and alveo devices (Xilinx#7882) Signed-off-by: Daniel Benusovich <[email protected]>

…e device BO metrics column. (Xilinx#7883) Signed-off-by: Daniel Benusovich <[email protected]>

…7884)

* VITIS-11097 Update AIE Reports * VITIS-11097 Update Info Message for aie reports * VITIS-11097 Update Info Message

* VITIS-10487 * VITIS-10487 * VITIS-10487 Signed-off-by: AShivangi <[email protected]> * fix formatting Signed-off-by: AShivangi <[email protected]> * fix windows build Signed-off-by: AShivangi <[email protected]> --------- Signed-off-by: AShivangi <[email protected]>

Xilinx#7866)

Signed-off-by: AShivangi <[email protected]>

Cleanup trace point infrastructure and remove code that is not used.

…instances (Xilinx#7891) Signed-off-by: Daniel Benusovich <[email protected]>

…7877) * Added all the OSs supported by XRT in os_supported.json file Signed-off-by: Manoj Takasi <[email protected]> * Update os_supported.json --------- Signed-off-by: Manoj Takasi <[email protected]>

…7893)

The field `drm_driver.gem_prime_mmap` was removed in Linux 6.6. XRT GEM object uses the function table `drm_gem_object_funcs xocl_gem_object_funcs` which has a field for the mmap function. This field should point to `xocl_gem_prime_mmap` instead. This is for xocl. The changes for zocl were done in 95db0f3. Details: torvalds/linux@0adec22 Signed-off-by: Gökçe Aydos <aydos.de> Co-authored-by: goekce <[email protected]>

* VITIS-11233 Add firmware version to ryzen platform report Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11233 Fix incorrect firmware_version key Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11233 Revert device class change Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11233 Improve firmware output for Ryzen Signed-off-by: Daniel Benusovich <[email protected]> --------- Signed-off-by: Daniel Benusovich <[email protected]>

…7905) Signed-off-by: Daniel Benusovich <[email protected]>

…linx#7859)

Signed-off-by: AShivangi <[email protected]>

…st (Xilinx#7918) Signed-off-by: Manoj Takasi <[email protected]>

…nx#7917)

Signed-off-by: Daniel Benusovich <[email protected]>

…inx#7902) * VITIS-11106 Remove requirement of -d,--device option for systems with a single device Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11106 Add documentiation change for -d requirement Signed-off-by: Daniel Benusovich <[email protected]> --------- Signed-off-by: Daniel Benusovich <[email protected]>

Co-authored-by: saumya garg <[email protected]>

)

* VITIS-11275 Add support for telemetry report in xrt core Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11275 Update docs to show new report Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11275 AFRemove extra keywords. Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11275 Show no info for telemetry if queries not implemented Signed-off-by: Daniel Benusovich <[email protected]> --------- Signed-off-by: Daniel Benusovich <[email protected]>

* Add hotfix for Linux xbutil validation implementation Signed-off-by: Daniel Benusovich <[email protected]> * CR-1189208 Add missing break statements Signed-off-by: Daniel Benusovich <[email protected]> * CR-1189208 Change dpu sequence location to XILINX_XRT Signed-off-by: Daniel Benusovich <[email protected]> --------- Signed-off-by: Daniel Benusovich <[email protected]>

Signed-off-by: Max Zhen <[email protected]>

Signed-off-by: King Tam <[email protected]>

Signed-off-by: Sonal Santan <[email protected]>

Co-authored-by: ch vamshi krishna <[email protected]>

Signed-off-by: Manoj Takasi <[email protected]>

Signed-off-by: Parth Jain <[email protected]> Co-authored-by: Parth Jain <[email protected]>

* add iterations to df-bw Signed-off-by: AShivangi <[email protected]> * build-fix Signed-off-by: AShivangi <[email protected]> --------- Signed-off-by: AShivangi <[email protected]>

…nx#7932)

Signed-off-by: AShivangi <[email protected]>

…information query from alveo device shim. (Xilinx#7945) Signed-off-by: Daniel Benusovich <[email protected]>

)

… correctly (Xilinx#7948)

Signed-off-by: Daniel Benusovich <[email protected]>

…compute units and monitors (Xilinx#7952)

* VITIS-11348 Initial changes for improve readability Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11348 Remove variable names with underscores Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11348 Fix windows path issue. Improve test logic path for TestVerify. Add comment headers Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11348 Movenew function into private area Signed-off-by: Daniel Benusovich <[email protected]> --------- Signed-off-by: Daniel Benusovich <[email protected]>

* Hip bindings initial implementation of device and context apis Signed-off-by: rbramand <[email protected]> * Added changes related to primary context Signed-off-by: rbramand <[email protected]> * Address comments on PR Signed-off-by: rbramand <[email protected]> * Change functions names to use lower_case instead of camel case Signed-off-by: rbramand <[email protected]> * Handle invalid ctx case Signed-off-by: rbramand <[email protected]> * Add comment explaining active hip context logic Signed-off-by: rbramand <[email protected]> --------- Signed-off-by: rbramand <[email protected]> Co-authored-by: rbramand <[email protected]>

) Allocate a “special” type of BO in a virtual region shared with instruction buffers within a hardware context. The driver will share this buffer object with firmware where the buffer will be populated with data to be shared with user space XRT. The implementation makes use of a new XRT_BO_USE_DEBUG flag which is ignored for all other use cases. The allocation of the debug buffer object is through an internal API which takes as argument the xrt::hw_context in which the buffer is to be allocated, plus the size of the debug buffer.

Signed-off-by: AShivangi <[email protected]>

Add internal API to set the read range of an xrt::ip object. Access to xclAPIs is being removed and everyone including internal XRT must use native objects for access shim functionality. For special deadlock detection, IPs have registers outside the adverticed address range. In order to read these registers, the address range must be expanded. This PR adds support for expanding the read range of an xrt::ip. Signed-off-by: Soren Soe <[email protected]>

* Enable clang-tidy for hip tests Add HIP multi-threaded stream test Signed-off-by: Sonal Santan <[email protected]> * Add missing call to stream destroy * DCO Remediation Commit for Sonal Santan <[email protected]> I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: 70b9a11 Signed-off-by: Sonal Santan <[email protected]> * Always enable clang-tidy in Debug configuration for hip runtime and hip test code Signed-off-by: Sonal Santan <[email protected]> --------- Signed-off-by: Sonal Santan <[email protected]>

…Path (Xilinx#7962)

* add initial support for transforming PDIs in AIE_PARTITION Signed-off-by: Fei Rui <[email protected]> * remove or comment out debug messages Signed-off-by: Fei Rui <[email protected]> * Update src/runtime_src/tools/xclbinutil/XclBinUtilities.cxx Co-authored-by: Ronan Keryell <[email protected]> * Update src/runtime_src/tools/xclbinutil/XclBinUtilities.cxx Co-authored-by: Ronan Keryell <[email protected]> * Update src/runtime_src/tools/xclbinutil/XclBinUtilMain.cxx Co-authored-by: Ronan Keryell <[email protected]> * Update src/runtime_src/tools/xclbinutil/XclBinUtilities.cxx Co-authored-by: Ronan Keryell <[email protected]> * Update src/runtime_src/tools/xclbinutil/XclBinUtilMain.cxx Co-authored-by: Ronan Keryell <[email protected]> * update the implementation based on the review feedback Signed-off-by: Fei Rui <[email protected]> * minor code cleanup Signed-off-by: Fei Rui <[email protected]> * remove binary files for unit-test Signed-off-by: Fei Rui <[email protected]> * remove binary files for unit-test Signed-off-by: Fei Rui <[email protected]> * fixed the indentation Signed-off-by: Fei Rui <[email protected]> * Update src/runtime_src/tools/xclbinutil/XclBinUtilities.cxx Co-authored-by: Soren Soe <[email protected]> * Update src/runtime_src/tools/xclbinutil/XclBinUtilities.cxx Co-authored-by: Soren Soe <[email protected]> * Update src/runtime_src/tools/xclbinutil/XclBinUtilMain.cxx Co-authored-by: Soren Soe <[email protected]> * Update src/runtime_src/tools/xclbinutil/XclBinClass.cxx Co-authored-by: Soren Soe <[email protected]> * Update src/runtime_src/tools/xclbinutil/XclBinClass.cxx Co-authored-by: Soren Soe <[email protected]> * update the code based on review feedback Signed-off-by: Fei Rui <[email protected]> * update the logic for locating transform_static Signed-off-by: Fei Rui <[email protected]> * update the logic for locating transform_static Signed-off-by: Fei Rui <[email protected]> * update the logic for locating transform_static Signed-off-by: Fei Rui <[email protected]> --------- Signed-off-by: Fei Rui <[email protected]> Co-authored-by: Ronan Keryell <[email protected]> Co-authored-by: Soren Soe <[email protected]>

* XRT build drops a kernel-doc directory in the PWD Signed-off-by: Manoj Takasi <[email protected]> * Modified changes according to suggestion. Signed-off-by: root <[email protected]> --------- Signed-off-by: Manoj Takasi <[email protected]> Signed-off-by: root <[email protected]> Co-authored-by: root <[email protected]>

* Fix help menu Signed-off-by: AShivangi <[email protected]> * build fix Signed-off-by: AShivangi <[email protected]> * update header Signed-off-by: AShivangi <[email protected]> --------- Signed-off-by: AShivangi <[email protected]>

* Removed mapping bars from the probe Signed-off-by: Manoj Takasi <[email protected]> * Removed bridge_mmap function from mgmt-core.c file. Signed-off-by: Manoj Takasi <[email protected]> * ioremap_nocache is deprecated from 5.15 Signed-off-by: Manoj Takasi <[email protected]> * Revert "Removed bridge_mmap function from mgmt-core.c file." This reverts commit 02da04c. Signed-off-by: Manoj Takasi <[email protected]> --------- Signed-off-by: Manoj Takasi <[email protected]> Signed-off-by: Manoj Takasi <[email protected]> Co-authored-by: Manoj Takasi <[email protected]> Co-authored-by: Manoj Takasi <[email protected]>

* stubs for hip memory API. (#6) Signed-off-by: Chiming Zhang <[email protected]> * Stubs for HIP memory APIs (#7) * stubs for hip memory API. Signed-off-by: Chiming Zhang <[email protected]> * fix some code formatting. Signed-off-by: Chiming Zhang <[email protected]> --------- Signed-off-by: Chiming Zhang <[email protected]> --------- Signed-off-by: Chiming Zhang <[email protected]>

* Clean up hip tests to please clang-tidy Signed-off-by: Sonal Santan <[email protected]> * Disable clang-tidy misleading __llvm_libc warnings Signed-off-by: Sonal Santan <[email protected]> * Host buffer allocation should be modeled as std::vector and not std::array as the latter has storage on stack. Signed-off-by: Sonal Santan <[email protected]> * Use static_cast for numerical casts Signed-off-by: Sonal Santan <[email protected]> --------- Signed-off-by: Sonal Santan <[email protected]>

…nx#7971) * CR-1191367 Package revision ID with device ID for better device categorization. Signed-off-by: Daniel Benusovich <[email protected]> * CR-1191367 Rename pcie_id query struct to be more descriptive. Signed-off-by: Daniel Benusovich <[email protected]> --------- Signed-off-by: Daniel Benusovich <[email protected]>

…ilinx#7969)

…nx#7974)

* xclbinutil changes to support multiple aie.resources.bin Signed-off-by: xvijaysri <[email protected]> * resolve warnings Signed-off-by: xvijaysri <[email protected]> * Update src/runtime_src/tools/xclbinutil/SectionAIEResourcesBin.cxx Co-authored-by: Stephen Rozum <[email protected]> Signed-off-by: xvijaysri <[email protected]> * Update src/runtime_src/tools/xclbinutil/SectionAIEResourcesBin.cxx Co-authored-by: Stephen Rozum <[email protected]> Signed-off-by: xvijaysri <[email protected]> * Update src/runtime_src/tools/xclbinutil/SectionAIEResourcesBin.cxx Co-authored-by: Stephen Rozum <[email protected]> Signed-off-by: xvijaysri <[email protected]> * suggested changes Signed-off-by: xvijaysri <[email protected]> --------- Signed-off-by: xvijaysri <[email protected]> Co-authored-by: Stephen Rozum <[email protected]>

* Initial implementation of module and function hip objects Signed-off-by: rbramand <[email protected]> * Add function for throwing error for reusability Signed-off-by: rbramand <[email protected]> * Address comments on PR Signed-off-by: rbramand <[email protected]> * Remove boiler plate code Signed-off-by: rbramand <[email protected]> --------- Signed-off-by: rbramand <[email protected]> Co-authored-by: rbramand <[email protected]>

The latest QDMA commit has the patch to support the RAVE-IVH bar issue Signed-off-by: bisingha <[email protected]>

Signed-off-by: Daniel Benusovich <[email protected]>

* event class implementation minor fix review suggestions minor change Signed-off-by: saumya garg <[email protected]> minor change Signed-off-by: saumya garg <[email protected]> minor change Signed-off-by: saumya garg <[email protected]> * review-fixes fix Signed-off-by: saumya garg <[email protected]> fix Signed-off-by: saumya garg <[email protected]> * fix review comments Signed-off-by: saumya garg <[email protected]> * doc update Signed-off-by: saumya garg <[email protected]> doc update2 Signed-off-by: saumya garg <[email protected]> * fix review comment Signed-off-by: saumya garg <[email protected]> * fix review comments Signed-off-by: saumya garg <[email protected]> fix Signed-off-by: saumya garg <[email protected]> * fix review comments Signed-off-by: saumya garg <[email protected]> fix review comments Signed-off-by: saumya garg <[email protected]> * fix review comments Signed-off-by: saumya garg <[email protected]> fix review comments Signed-off-by: saumya garg <[email protected]> --------- Signed-off-by: saumya garg <[email protected]> Co-authored-by: saumya garg <[email protected]>

* Fix seg fault when device not available is provided Signed-off-by: rbramand <[email protected]> * Fix missing increment in loop Signed-off-by: rbramand <[email protected]> --------- Signed-off-by: rbramand <[email protected]> Co-authored-by: rbramand <[email protected]>

)

* VITIS-11114 - HIP API initial Implementarion Signed-off-by: Homa Aghilinasab <[email protected]> * Addressing Comments Signed-off-by: Homa Aghilinasab <[email protected]> * Applying Comments Signed-off-by: Homa Aghilinasab <[email protected]> * Addressing the comments Signed-off-by: Homa Aghilinasab <[email protected]> * Address the comments Signed-off-by: Homa Aghilinasab <[email protected]> --------- Signed-off-by: Homa Aghilinasab <[email protected]>

Signed-off-by: rbramand <[email protected]> Co-authored-by: rbramand <[email protected]>

minor Signed-off-by: saumya garg <[email protected]> Co-authored-by: saumya garg <[email protected]>

Signed-off-by: AShivangi <[email protected]>

Signed-off-by: Ryan Chane <[email protected]>

…FT QDMA IP. (Xilinx#7979) * QDMA Patch for Aperture Size Limit * string compare changes Signed-off-by: DMG Karthik <[email protected]> * format changes Signed-off-by: DMG Karthik <[email protected]> * correction Signed-off-by: DMG Karthik <[email protected]> * validate change Signed-off-by: DMG Karthik <[email protected]> --------- Signed-off-by: DMG Karthik <[email protected]>

> Conversion of xclBufferHandle to xrtBufferHandle is deprecated > Added internal shim function which converts buffer fd to buffer_handle > This way use of xcl buffer shim apis can be eliminated Signed-off-by: rbramand <[email protected]> Co-authored-by: rbramand <[email protected]>

* Initial changes Signed-off-by: DMG Karthik <[email protected]> * Removed lines Signed-off-by: DMG Karthik <[email protected]> * Validation changes Signed-off-by: DMG Karthik <[email protected]> * QDMA Patch for Aperture Size Limit * persist size changes * string compare changes Signed-off-by: DMG Karthik <[email protected]> * format changes Signed-off-by: DMG Karthik <[email protected]> * correction Signed-off-by: DMG Karthik <[email protected]> * validate change Signed-off-by: DMG Karthik <[email protected]> * sensor size preserve changes Signed-off-by: DMG Karthik <[email protected]> --------- Signed-off-by: DMG Karthik <[email protected]>

…itored APIs (Xilinx#8000)

…y modules in AIE profile & trace (Xilinx#7990)

Signed-off-by: Max Zhen <[email protected]>

This triggered a warning about pessimistic behavior preventing copy-elision. It was treated as an error by the normal compilation flow.. Signed-off-by: Ronan Keryell <[email protected]>

* master pipeline for xrt * adding on workflow dispatch as well * setting prod to true

* add xrt::elf raw elf data constructor * rename * review comment * review comments Signed-off-by: HimanshuChoudhary-Xilinx <[email protected]> --------- Signed-off-by: HimanshuChoudhary-Xilinx <[email protected]>

…8012) * master pipeline for xrt * adding on workflow dispatch as well * setting prod to true * modifying build number for TA * TA build no fix

* fixing build number for windows

* Adding os_ver

Signed-off-by: Manoj Takasi <[email protected]> Co-authored-by: Manoj Takasi <[email protected]>

* Hide symbols from xrt.h header Signed-off-by: rbramand <[email protected]> * Unhide symbols xclProbe, xclGetDeviceInfo2, xclVersion for making opencl tests pass Signed-off-by: rbramand <[email protected]> * Cleanup Hal opeartions to not use xcl apis > cleaned up functions that were using Hal ops to use core device functions > for some functions direct replacement is not found and they will be cleaned in next PR > Most of them are prodiling functions Signed-off-by: rbramand <[email protected]> * Address comments on PR > addressed comments on PR > fixed windows build Signed-off-by: rbramand <[email protected]> * Remove Hal operations completely Signed-off-by: rbramand <[email protected]> * Address comments on PR Signed-off-by: rbramand <[email protected]> --------- Signed-off-by: rbramand <[email protected]> Co-authored-by: rbramand <[email protected]>

* VITIS-11369 Update validate path finding to rely on xclbin types. Improve system paths for Linux and Windows. Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11369 Add deprecation comment for findPlatformPath. Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11369 Add query request for sequence path. Signed-off-by: Daniel Benusovich <[email protected]> --------- Signed-off-by: Daniel Benusovich <[email protected]>

…nd Event API Implementation Part1 (Xilinx#8007) * Command and its children class Implementation Part1 Signed-off-by: Homa Aghilinasab <[email protected]> * Addressing the comments Signed-off-by: Homa Aghilinasab <[email protected]> * Addressing the comments Signed-off-by: Homa Aghilinasab <[email protected]> * Addressing the comments Signed-off-by: Homa Aghilinasab <[email protected]> * add dynamic cast null and better name for iterator Signed-off-by: Homa Aghilinasab <[email protected]> * small change Signed-off-by: Homa Aghilinasab <[email protected]> * add comments Signed-off-by: Homa Aghilinasab <[email protected]> --------- Signed-off-by: Homa Aghilinasab <[email protected]>

* Added makefiles to exercise HIP tests on GPU Signed-off-by: Sonal Santan <[email protected]> * Add a switch to enable(default)/disable bundling of Alveo drivers with XRT Fix a build failure on Ubuntu 23.10 due to an illegal std::move of a temporary object returned by create_profiling_event() Signed-off-by: Sonal Santan <[email protected]> * Add check for optional alveo driver install in postinst script Signed-off-by: Sonal Santan <[email protected]> * Update copyright notice to include 2024 Signed-off-by: Sonal Santan <[email protected]> * When Alveo is disabled do not bundle ERT firmware and xbflash2 Signed-off-by: Sonal Santan <[email protected]> * Fix build error Signed-off-by: Sonal Santan <[email protected]> --------- Signed-off-by: Sonal Santan <[email protected]>

* QDMA Patch for Aperture Size Limit * string compare changes Signed-off-by: DMG Karthik <[email protected]> * format changes Signed-off-by: DMG Karthik <[email protected]> * correction Signed-off-by: DMG Karthik <[email protected]> * validate change Signed-off-by: DMG Karthik <[email protected]> * Initial commit Signed-off-by: DMG Karthik <[email protected]> --------- Signed-off-by: DMG Karthik <[email protected]>

…#7999) * XRT support for independent AIE graph compilation and linking Signed-off-by: saumya garg <[email protected]> fix review comments Signed-off-by: saumya garg <[email protected]> properly parsed Signed-off-by: saumya garg <[email protected]> * fix review comments Signed-off-by: saumya garg <[email protected]> * minor fix Signed-off-by: saumya garg <[email protected]> --------- Signed-off-by: saumya garg <[email protected]> Co-authored-by: saumya garg <[email protected]>

Xilinx#8022) * Update cmake to pick up HIP header files from Linux distribution area if available Fix another build failure on Ubuntu 23.10 Disable xcl API tests in tests/xrt directory Signed-off-by: Sonal Santan <[email protected]> * Remove commented out action from CMakeLists.txt Signed-off-by: Sonal Santan <[email protected]> --------- Signed-off-by: Sonal Santan <[email protected]>

Signed-off-by: Daniel Benusovich <[email protected]>

adjusting build number for TA to pick up

* adding new job notify-slack on failure * notify slack depends only on gradle-artifactory-upload job * notify slack depends on release to all sites and gradle artifactory upload

…meline Plugin (Xilinx#8025)

* fixing version file generation issue * fixing the checkout issue with windows in master build

Signed-off-by: Daniel Benusovich <[email protected]>

* VITIS-11100 Refactor asd parser to better group columns and its tiles. Create separate report for AIE2 devices for core tile output. Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11100 Refactor asd parser to reduce complexity. Add AIE2 mem report. Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11100 Refactor common AIE2 code into utility function. Add AIE2 shim report. Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11100 Refactor lock table creation to utility file Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11100 Improve display of aie reports Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11100 Remove AIE2 logic from AIE parsing. Remove extraneous definitions from AIE2 parser. Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11100 Rename asd_parser into info_aie2 Signed-off-by: Daniel Benusovich <[email protected]> --------- Signed-off-by: Daniel Benusovich <[email protected]>

…ilinx#8030) * xrt support for multiple graph linking and compilation Signed-off-by: saumya garg <[email protected]> xrt support for multiple graph linking and compilation Signed-off-by: saumya garg <[email protected]> xrt support for multiple graph linking and compilation Signed-off-by: saumya garg <[email protected]> xrt support for multiple graph linking and compilation Signed-off-by: saumya garg <[email protected]> xrt support for multiple graph linking and compilation Signed-off-by: saumya garg <[email protected]> * fix review comments Signed-off-by: saumya garg <[email protected]> fix review comments Signed-off-by: saumya garg <[email protected]> --------- Signed-off-by: saumya garg <[email protected]> Co-authored-by: saumya garg <[email protected]>

* Initial implementation of some HIP memory APIs. (#11) Signed-off-by: Chiming Zhang <[email protected]> * Add hipMemset(). (#12) Signed-off-by: Chiming Zhang <[email protected]> * minor fix to hipHostMalloc() (#13) Signed-off-by: Chiming Zhang <[email protected]> * Fix the typo. (#14) Signed-off-by: Chiming Zhang <[email protected]> * fix some issues from code review. Signed-off-by: Chiming Zhang <[email protected]> * fix minor error in error.cpp. Signed-off-by: Chiming Zhang <[email protected]> * remove new operation from memory_database::GetInstance(). Signed-off-by: Chiming Zhang <[email protected]> * Fix some issues from code review. Signed-off-by: Chiming Zhang <[email protected]> * change class name error_state to error. Signed-off-by: Chiming Zhang <[email protected]> * remove some duplicate code. Signed-off-by: Chiming Zhang <[email protected]> * fix some issues. Signed-off-by: Chiming Zhang <[email protected]> * fix some issues. Signed-off-by: Chiming Zhang <[email protected]> * fix more issues. Signed-off-by: Chiming Zhang <[email protected]> * fix more issues. Signed-off-by: Chiming Zhang <[email protected]> --------- Signed-off-by: Chiming Zhang <[email protected]>

…8033)

* eventfd_signal() has only 1 parameter starting with Linux 6.8 This follows kernel commit 3652117f854819a148ff0fbe4492587d3520b5e5 https://lore.kernel.org/all/[email protected]/ Signed-off-by: Ronan Keryell <[email protected]> * Do not use obsolete strlcpy() removed in Linux 6.8 anyway Interestingly, the newer strscpy() matches exactly the return behavior of get_vendor_firmware_dir() API. strlcpy() has been removed in Linux 6.8 by commit d26270061ae66b915138af7cd73ca6f8b85e6b44. For the context: https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy KSPP/linux#89 Signed-off-by: Ronan Keryell <[email protected]> * Use portable MAX_ORDER_NR_PAGES instead of confusing MAX_ORDER MAX_ORDER was replaced partially with MAX_PAGE_ORDER starting with Linux 6.8 anyway. Cf Linux commits fd37721803c6e73619108f76ad2e12a9aa5fafaf and 5e0a760b44417f7cadd79de2204d6247109558a0 https://lwn.net/Articles/956321/ https://lwn.net/ml/linux-kernel/[email protected]/ https://lwn.net/ml/linux-kernel/[email protected]/ Signed-off-by: Ronan Keryell <[email protected]> * Remove DRM_UNLOCKED usage that has disappeared with Linux 6.8 This was removed in Linux with commit 2798ffcc1d6a788b5769b1fbcf0750dfc06ae98a https://lwn.net/Articles/952344/ https://patchwork.freedesktop.org/patch/msgid/[email protected] Signed-off-by: Ronan Keryell <[email protected]> --------- Signed-off-by: Ronan Keryell <[email protected]>

…e no Memory Module is used (Xilinx#8035)

* changing some interfaces of hip memory * simplfying the interfaces of hip memory * fixed a comment --------- Co-authored-by: ch vamshi krishna <[email protected]> Co-authored-by: rbramand <[email protected]>

* More clang-tidy cleanups Signed-off-by: Sonal Santan <[email protected]> * Move hip test common.h to a common directory for use by all hip testcases Signed-off-by: Sonal Santan <[email protected]> * Fix reading of map value from iterator end Enclose definitions in common.h in a namespace Signed-off-by: Sonal Santan <[email protected]> --------- Signed-off-by: Sonal Santan <[email protected]>

* Initial implementation of hip stream apis Signed-off-by: rbramand <[email protected]> * Update stream with event changes Signed-off-by: rbramand <[email protected]> * Address comments on PR Signed-off-by: rbramand <[email protected]> * Add ASCII diagram explaining about stream Signed-off-by: rbramand <[email protected]> * Rebase with memory changes Signed-off-by: rbramand <[email protected]> --------- Signed-off-by: rbramand <[email protected]> Co-authored-by: rbramand <[email protected]>

* fixing the map logic * fixing the map logic --------- Co-authored-by: rbramand <[email protected]>

Signed-off-by: rbramand <[email protected]> Co-authored-by: rbramand <[email protected]>

Xilinx#8045)

Signed-off-by: DMG Karthik <[email protected]>

QDMA blindly registers intr for mailbox even if its disabled on the hw. NOTE: this is a workaround to move forward with this https://jira.xilinx.com/browse/CR-1193112 Once QDMA fixes the issue this commit should be reverted Signed-off-by: bisingha <[email protected]>

…ilinx#8054) Co-authored-by: dezhliao <[email protected]>

…n be done (Xilinx#8043) * VITIS-11503 - Dump instruction bo created from Elf so verification can be done * VITIS-11503 -respond to review comments * VITIS-11503 Add a function dump_bo for reuse * VITIS-11503 - change function dump_bo under unnamed space * VITIS-11503 - early return in function dump_bo if feature is not enabled * VITIS-11503 A function unused in release builds must have XRT_CORE_UNUSED --------- Co-authored-by: dezhliao <[email protected]>

aie-status reports fix Signed-off-by: saumya garg <[email protected]> Co-authored-by: saumya garg <[email protected]>

…linx#8053) On rave we dont have SC. Added extra checks to handle unnecessary warnings. Updated the checks to check the xsabin extension for the flash images Signed-off-by: bisingha <[email protected]>

…#8047) * fixing the map logic * fixing the map logic * providing workaround for instruction buffer * fixing indentation * using xrt::bo instead of shared_ptr of xrt::bo Signed-off-by: ch vamshi krishna <[email protected]> --------- Signed-off-by: ch vamshi krishna <[email protected]> Co-authored-by: rbramand <[email protected]>

Relatively benign fixes to core/common/api to satisyfy clang-tidy. Signed-off-by: Soren Soe <[email protected]>

Signed-off-by: Aaron Pinto <[email protected]> Co-authored-by: Aaron Pinto <[email protected]>

* VITIS-11832 - First version * Add control packet patching * Change c-style cast to c++ style cast * Add comment about reusing patching scheme --------- Co-authored-by: dezhliao <[email protected]>

Add first class experimental API for xrt::runlist. class runlist - A class to manage a list of xrt::run objects This class is used to manage a list of xrt::run objects such that they can be executed atomically in the order they are added to the list. Run objects are added to the list using the add() method. A runlist is submitted for execution using the execute() method. Once the list is executing, no more run objects can be added until execution of the current last run object has completed. The list can be reset using the reset() method, which will clear all run objects, or the list can be reused by calling execute() again maybe with additional run objects. There is no support for removing individual run objects from the list. Check experimental/xrt_kernel.h for more documentation. Signed-off-by: Soren Soe <[email protected]>

…inx#8065)

…tiles metric for PLIO designs (Xilinx#8064)

* Initial implementation of some HIP memory APIs. (#11) Signed-off-by: Chiming Zhang <[email protected]> * Add hipMemset(). (#12) Signed-off-by: Chiming Zhang <[email protected]> * minor fix to hipHostMalloc() (#13) Signed-off-by: Chiming Zhang <[email protected]> * Fix the typo. (#14) Signed-off-by: Chiming Zhang <[email protected]> * fix some issues from code review. Signed-off-by: Chiming Zhang <[email protected]> * fix minor error in error.cpp. Signed-off-by: Chiming Zhang <[email protected]> * remove new operation from memory_database::GetInstance(). Signed-off-by: Chiming Zhang <[email protected]> * Fix some issues from code review. Signed-off-by: Chiming Zhang <[email protected]> * change class name error_state to error. Signed-off-by: Chiming Zhang <[email protected]> * remove some duplicate code. Signed-off-by: Chiming Zhang <[email protected]> * fix some issues. Signed-off-by: Chiming Zhang <[email protected]> * fix some issues. Signed-off-by: Chiming Zhang <[email protected]> * fix more issues. Signed-off-by: Chiming Zhang <[email protected]> * fix more issues. Signed-off-by: Chiming Zhang <[email protected]> * Add hipMemcpyHtoDAsync(). (#15) Signed-off-by: Chiming Zhang <[email protected]> * Add hipMemcpyHtoDAsync(). (#16) * Add hipMemcpyHtoDAsync(). Signed-off-by: Chiming Zhang <[email protected]> * enque copy_buffer command instead of submitting directly. Signed-off-by: Chiming Zhang <[email protected]> --------- Signed-off-by: Chiming Zhang <[email protected]> * Add check for invalid size in hipMemcpyHtoDAsync(). Signed-off-by: Chiming Zhang <[email protected]> * remove free() from hip_memset(). Signed-off-by: Chiming Zhang <[email protected]> * add missing async policy in copy_buffer::submit(). Signed-off-by: Chiming Zhang <[email protected]> * Add missing handling of parameter size in hipMemcpyHtoDAsync(). Signed-off-by: Chiming Zhang <[email protected]> * Add missing offset in hipMemcpyHtoDAsync(). Signed-off-by: Chiming Zhang <[email protected]> * change return type of memory_database::get_hip_mem_from_addr() Signed-off-by: Chiming Zhang <[email protected]> --------- Signed-off-by: Chiming Zhang <[email protected]>

Compilation of header file requires inclusion of cstdint. Signed-off-by: Soren Soe <[email protected]>

* Addressing all comments and rebase Signed-off-by: Homa Aghilinasab <[email protected]> * fixing lvalue/rvalue issue Signed-off-by: Homa Aghilinasab <[email protected]> * Add missed lock Signed-off-by: Homa Aghilinasab <[email protected]> --------- Signed-off-by: Homa Aghilinasab <[email protected]>

Signed-off-by: saumya garg <[email protected]> Co-authored-by: saumya garg <[email protected]>

Checking extra packages upload-1 #268

Checking extra packages upload-1 #268

Commits on Dec 11, 2023

Commits on Dec 12, 2023

Commits on Dec 14, 2023

Commits on Dec 15, 2023

Commits on Dec 18, 2023

Commits on Dec 19, 2023

Commits on Dec 20, 2023

Commits on Dec 21, 2023

Commits on Dec 22, 2023

Commits on Dec 27, 2023

Commits on Dec 28, 2023

Commits on Jan 3, 2024

Commits on Jan 5, 2024

Commits on Jan 6, 2024

Commits on Jan 9, 2024

Commits on Jan 10, 2024

Commits on Jan 15, 2024

Commits on Jan 16, 2024

Commits on Jan 17, 2024

Commits on Jan 18, 2024

Commits on Jan 19, 2024

Commits on Jan 22, 2024

Commits on Jan 23, 2024

Commits on Jan 24, 2024

Commits on Jan 25, 2024

Commits on Jan 30, 2024

Commits on Jan 31, 2024

Commits on Feb 2, 2024

Commits on Feb 6, 2024

Commits on Feb 8, 2024

Commits on Feb 9, 2024

Commits on Feb 10, 2024

Commits on Feb 11, 2024

Commits on Feb 13, 2024

Commits on Feb 14, 2024

Commits on Feb 15, 2024

Commits on Feb 16, 2024

Commits on Feb 17, 2024

Commits on Feb 19, 2024

Commits on Feb 20, 2024

Commits on Feb 22, 2024

Commits on Feb 23, 2024

Commits on Feb 24, 2024

Commits on Feb 27, 2024

Commits on Feb 28, 2024

Commits on Feb 29, 2024

Commits on Mar 3, 2024

Commits on Mar 4, 2024

Commits on Mar 5, 2024

Commits on Mar 6, 2024

Commits on Mar 9, 2024

Commits on Mar 11, 2024

Commits on Mar 12, 2024

Commits on Mar 13, 2024

Commits on Mar 14, 2024

Commits on Mar 15, 2024

Commits on Mar 16, 2024

Commits on Mar 18, 2024

Commits on Mar 19, 2024

Commits on Mar 20, 2024

Commits on Mar 21, 2024

Commits on Mar 22, 2024

Commits on Mar 23, 2024

Commits on Mar 25, 2024

Commits on Mar 26, 2024

Commits on Mar 27, 2024

Commits on Mar 29, 2024

Commits on Apr 1, 2024

Commits on Apr 2, 2024

Commits on Apr 3, 2024

Commits on Apr 4, 2024

Commits on Apr 5, 2024

Commits on Apr 7, 2024

Commits on Apr 9, 2024

Commits on Apr 10, 2024

Commits on Apr 11, 2024

Commits on Apr 12, 2024

Commits on Apr 15, 2024