Checking extra packages upload-1 #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* patch fix for checkout in GHA * fixing the checkout for windows too
* CR-1183009 Fix mem-bw and verify bugs in validate * CR-1183009 Fix kernel run waiting, revert iterations * CR-1183009 Fix verify to check for hello kernel in absence of platform.json * CR-1183009 Fix Windows comiple error * CR-1183009 Check for hello in verify.xclbin for IOPS test * CR-1183009 Use krnl.name for hello kernel
Co-authored-by: ch vamshi krishna <[email protected]>
#1) (Xilinx#7835) Problem solved by the commit Enabled setting XRT install prefix to custom location on Linux build. Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered Xilinx#6783 How problem was solved, alternative solutions (if any) and why they were rejected Modified corresponding CMake files, Makefiles and build scripts. Risks (if any) associated the changes in the commit Low What has been tested and how, request additional testing if necessary Built XRT on Ubuntu 22.04. Documentation impact (if any) NA Signed-off-by: Chiming Zhang <[email protected]>
…#7836) * [NFC] Remove random TAB and spaces This file would require a serious beautifier. Signed-off-by: Ronan Keryell <[email protected]> * Add missing apt-get update to have an up-to-date package list Signed-off-by: Ronan Keryell <[email protected]> --------- Signed-off-by: Ronan Keryell <[email protected]>
…7847) * Fix-CR-1183009 Use py test when there is no platform.json for mem-bw * Fix-CR-1183009 Remove duplicate busybar from runScript
* Fixing XRT issue for Ubuntu 23.10 Signed-off-by: Homa Aghilinasab <[email protected]> * Fixing XRT issue for Ubuntu 23.10 Signed-off-by: Homa Aghilinasab <[email protected]> * Fixing XRT issue for Ubuntu 23.10 Signed-off-by: Homa Aghilinasab <[email protected]> * Fixing XRT issue for Ubuntu 23.10 Signed-off-by: Homa Aghilinasab <[email protected]> --------- Signed-off-by: Homa Aghilinasab <[email protected]>
…ilinx#7855) Adjust copying of wchar[] array into std::wstring accounting for bytes vs wchar. Code queries windows adpater for driver store path. The driver store path is returned as array of wchar but was copied as bytes, resulting in copying from unallocated memory. This bug was introduced in Xilinx#7679 and is present in MCDM drops starting M6. Signed-off-by: Soren Soe <[email protected]>
Signed-off-by: Manoj Takasi <[email protected]>
…7857) * Skeleton directory and build infrastructure for HIP bindings Very preliminary infra for HIP bindings. Build on linux with `build.sh -hip [other options]` Signed-off-by: Soren Soe <[email protected]> * Review comments --------- Signed-off-by: Soren Soe <[email protected]>
…nx#7856) * VITIS-10910 Separate ryzen and alveo device lists within ReportHost Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-10910 Separate json generation for ryzen cards for host report Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-10910 Fix indentation Signed-off-by: Daniel Benusovich <[email protected]> --------- Signed-off-by: Daniel Benusovich <[email protected]>
Signed-off-by: Quentin Berthet <[email protected]> Co-authored-by: Quentin Berthet <[email protected]>
…inux9 (Xilinx#7861) * Update the dependency installation script to work on almalinux9 Signed-off-by: Quentin Berthet <[email protected]> * Allow to build and package on AlmaLinux9 Signed-off-by: Quentin Berthet <[email protected]> --------- Signed-off-by: Quentin Berthet <[email protected]> Co-authored-by: Quentin Berthet <[email protected]>
…present (Xilinx#7862) Signed-off-by: Daniel Benusovich <[email protected]>
Fix regression introduced in Xilinx#7177. Make sure non-trivially destructible static global objects, that act as a cache, are not accessed during static global destruction. If application code keep global XRT device objects, then these can end up accessing non-trivially destructible objects during static global destruction. Keep a terminal trivially destructible static global (a POD type object) that is destructed prior to the non-trivially ones. Test the POD type object before accessing the complex globals. Better to redesign and remove the need for these static global cache objects, but that has to other implications. Signed-off-by: Soren Soe <[email protected]>
* Workaround for cpack failure on Ubuntu 23.10 * cpack workaround is only for Ubuntu 23.10 * DCO Remediation Commit for Sonal Santan <[email protected]> I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: 3863648 I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: eed3e30 Signed-off-by: Sonal Santan <[email protected]> --------- Signed-off-by: Sonal Santan <[email protected]>
* Initial changes for removal of xcl apis Signed-off-by: rbramand <[email protected]> * Fix build failure Signed-off-by: rbramand <[email protected]> * Fix review comments Signed-off-by: rbramand <[email protected]> --------- Signed-off-by: rbramand <[email protected]> Co-authored-by: rbramand <[email protected]>
Signed-off-by: Manoj Takasi <[email protected]>
…tall (Xilinx#7867) * Add upstream HIP as submodule to get header file definitions * A simple vadd example for hip * Added support for installing hip-dev -- which provides the official HIP header files -- from the Linux distribution * Updated build infra to use HIP header files from HIP install area * Add comment about defining __HIP_PLATFORM_AMD__ * Drop installation of hip.h file * Minor code adjustments Signed-off-by: Sonal Santan <[email protected]> * DCO Remediation Commit for Sonal Santan <[email protected]> I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: a91d26b I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: d384c9f I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: 5076b02 I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: a394207 I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: ab75f5c I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: 18de09c Signed-off-by: Sonal Santan <[email protected]> * Improve the cmake handling of HIP for XRT to reduce warning messages Enable building of HIP tests for XRT along with xrt and unit_test * Remove redundant directory for vadd * Code updates to address style issues Add CMake based build of hip testcases Signed-off-by: Sonal Santan <[email protected]> * DCO Remediation Commit for Sonal Santan <[email protected]> I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: 747b2f3 I, Sonal Santan <[email protected]>, hereby add my Signed-off-by to this commit: dc9eabf Signed-off-by: Sonal Santan <[email protected]> * Drop usage of boost in hip testcases Signed-off-by: Sonal Santan <[email protected]> * Change the PASS/FAIL string to XRT standard Signed-off-by: Sonal Santan <[email protected]> --------- Signed-off-by: Sonal Santan <[email protected]>
Signed-off-by: Manoj Takasi <[email protected]>
* Script to enable building of tests directory in CI Signed-off-by: Sonal Santan <[email protected]> * Script to enable building of tests directory in CI Signed-off-by: Sonal Santan <[email protected]> --------- Signed-off-by: Sonal Santan <[email protected]>
…Xilinx#7875) Share the ownership of xrt_core::hwqueue_handle with shim. A hwqueue is managed by hwctx (today 1:1), and used by coreutil XRT (coreutil) for submitting commands for execution and more. XRT shim may itself use the hwqueue for miscellaneous commands and as such the underlying queue is actually owned by shim (hwctx_handle) but shared with coreutil. This PR makes it explicit that the hwqueue ownership is with the hwctx_handle. XRT coreutil no longer creates a hwqueue but instead gets a hwqueue_handle from the hwctx_handle. Prior to this change, there were strange hacks at shim level to return a unique_ptr to something that is actually shared. This strange logic can now be changed. It is the responsibility of XRT coreutil to ensure that lifetime of a hwctx extends the use of the hwqueue_handle that was obtained from the hwctx_handle. Signed-off-by: Soren Soe <[email protected]>
* Refactor XRT to cache created devices Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11043 Add export for report functions Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11043 Fix comment headers Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11043 Return mgmt device when requested instead of user device Signed-off-by: Daniel Benusovich <[email protected]> * VITIS-11043 Convert map to vector for device caching. Add mutex to protect device initialization. Signed-off-by: Daniel Benusovich <[email protected]> --------- Signed-off-by: Daniel Benusovich <[email protected]>
Signed-off-by: rbramand <[email protected]> Co-authored-by: rbramand <[email protected]>
Signed-off-by: DMG Karthik <[email protected]>
QDMA blindly registers intr for mailbox even if its disabled on the hw.
NOTE: this is a workaround to move forward with this https://jira.xilinx.com/browse/CR-1193112
Once QDMA fixes the issue this commit should be reverted
Signed-off-by: bisingha <[email protected]>
…ilinx#8054) Co-authored-by: dezhliao <[email protected]>
…n be done (Xilinx#8043) * VITIS-11503 - Dump instruction bo created from Elf so verification can be done * VITIS-11503 -respond to review comments * VITIS-11503 Add a function dump_bo for reuse * VITIS-11503 - change function dump_bo under unnamed space * VITIS-11503 - early return in function dump_bo if feature is not enabled * VITIS-11503 A function unused in release builds must have XRT_CORE_UNUSED --------- Co-authored-by: dezhliao <[email protected]>
aie-status reports fix Signed-off-by: saumya garg <[email protected]> Co-authored-by: saumya garg <[email protected]>
…linx#8053) On rave we dont have SC. Added extra checks to handle unnecessary warnings. Updated the checks to check the xsabin extension for the flash images Signed-off-by: bisingha <[email protected]>
…#8047) * fixing the map logic * fixing the map logic * providing workaround for instruction buffer * fixing indentation * using xrt::bo instead of shared_ptr of xrt::bo Signed-off-by: ch vamshi krishna <[email protected]> --------- Signed-off-by: ch vamshi krishna <[email protected]> Co-authored-by: rbramand <[email protected]>
Relatively benign fixes to core/common/api to satisyfy clang-tidy. Signed-off-by: Soren Soe <[email protected]>
Signed-off-by: Aaron Pinto <[email protected]> Co-authored-by: Aaron Pinto <[email protected]>
* VITIS-11832 - First version * Add control packet patching * Change c-style cast to c++ style cast * Add comment about reusing patching scheme --------- Co-authored-by: dezhliao <[email protected]>
Add first class experimental API for xrt::runlist. class runlist - A class to manage a list of xrt::run objects This class is used to manage a list of xrt::run objects such that they can be executed atomically in the order they are added to the list. Run objects are added to the list using the add() method. A runlist is submitted for execution using the execute() method. Once the list is executing, no more run objects can be added until execution of the current last run object has completed. The list can be reset using the reset() method, which will clear all run objects, or the list can be reused by calling execute() again maybe with additional run objects. There is no support for removing individual run objects from the list. Check experimental/xrt_kernel.h for more documentation. Signed-off-by: Soren Soe <[email protected]>
…tiles metric for PLIO designs (Xilinx#8064)
* Initial implementation of some HIP memory APIs. (#11) Signed-off-by: Chiming Zhang <[email protected]> * Add hipMemset(). (#12) Signed-off-by: Chiming Zhang <[email protected]> * minor fix to hipHostMalloc() (#13) Signed-off-by: Chiming Zhang <[email protected]> * Fix the typo. (#14) Signed-off-by: Chiming Zhang <[email protected]> * fix some issues from code review. Signed-off-by: Chiming Zhang <[email protected]> * fix minor error in error.cpp. Signed-off-by: Chiming Zhang <[email protected]> * remove new operation from memory_database::GetInstance(). Signed-off-by: Chiming Zhang <[email protected]> * Fix some issues from code review. Signed-off-by: Chiming Zhang <[email protected]> * change class name error_state to error. Signed-off-by: Chiming Zhang <[email protected]> * remove some duplicate code. Signed-off-by: Chiming Zhang <[email protected]> * fix some issues. Signed-off-by: Chiming Zhang <[email protected]> * fix some issues. Signed-off-by: Chiming Zhang <[email protected]> * fix more issues. Signed-off-by: Chiming Zhang <[email protected]> * fix more issues. Signed-off-by: Chiming Zhang <[email protected]> * Add hipMemcpyHtoDAsync(). (#15) Signed-off-by: Chiming Zhang <[email protected]> * Add hipMemcpyHtoDAsync(). (#16) * Add hipMemcpyHtoDAsync(). Signed-off-by: Chiming Zhang <[email protected]> * enque copy_buffer command instead of submitting directly. Signed-off-by: Chiming Zhang <[email protected]> --------- Signed-off-by: Chiming Zhang <[email protected]> * Add check for invalid size in hipMemcpyHtoDAsync(). Signed-off-by: Chiming Zhang <[email protected]> * remove free() from hip_memset(). Signed-off-by: Chiming Zhang <[email protected]> * add missing async policy in copy_buffer::submit(). Signed-off-by: Chiming Zhang <[email protected]> * Add missing handling of parameter size in hipMemcpyHtoDAsync(). Signed-off-by: Chiming Zhang <[email protected]> * Add missing offset in hipMemcpyHtoDAsync(). Signed-off-by: Chiming Zhang <[email protected]> * change return type of memory_database::get_hip_mem_from_addr() Signed-off-by: Chiming Zhang <[email protected]> --------- Signed-off-by: Chiming Zhang <[email protected]>
Compilation of header file requires inclusion of cstdint. Signed-off-by: Soren Soe <[email protected]>
* Addressing all comments and rebase Signed-off-by: Homa Aghilinasab <[email protected]> * fixing lvalue/rvalue issue Signed-off-by: Homa Aghilinasab <[email protected]> * Add missed lock Signed-off-by: Homa Aghilinasab <[email protected]> --------- Signed-off-by: Homa Aghilinasab <[email protected]>
Signed-off-by: saumya garg <[email protected]> Co-authored-by: saumya garg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.