Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable init values for Object FIFO #1813

Open
wants to merge 86 commits into
base: main
Choose a base branch
from
Open

Enable init values for Object FIFO #1813

wants to merge 86 commits into from

Conversation

AndraBisca
Copy link
Collaborator

@AndraBisca AndraBisca commented Oct 2, 2024 •
edited
Loading

This PR builds on top of #1801 to enable objectfifos to take as input an array of initial values.

Specifically:

  • initial values should be of the MLIR type ElementsAttr,
  • the above should also be of the same memref type as the objectfifo type,
  • the initial values array should be of the same size as the depth of the objectfifo,
  • the objectfifo lowering is modified to generate AIE_LockOps with init values such that the initialized objects will not be overwritten before they are communicated to the consumer(s).

This test shows a vector_vector_add example where one of the vectors is initialized in L2 with an objectfifo.

Builds on top of #1842

abisca and others added 30 commits October 1, 2024 08:19
@abisca
Add syntax for objfifo with init values. Add test.
8ea65ef
@abisca
Modify objectfifo lowering to generate buffers with init values. Adju…
a60dd56 
…st lock init values.
@abisca
Start changing from dense of arrays to array of dense.
6aa2d25
@abisca
Add repeat support for compute tiles.
92fa41b
@abisca
Add test
d8c177d
@abisca
Remove unnecessary file
edab881
@abisca
Add min value constraint for repeat_count
d530ea9
@abisca
Merge with main and fix conflicts. Temporarily keep deleted prog_exam…
7cf14b1 
…ples for debug.
@AndraBisca @github-actions
Update lib/Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp
4404ae1 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@abisca
Fix tests. Remove generation of repeatCount attribute for compute til…
26a5725 
…e DMAs from objectfifo repeatCount.
@abisca
Merge branch 'compute-tile-repeat' of https://github.com/Xilinx/mlir-aie
839c11d 
 into compute-tile-repeat
@abisca
Remove ability to infer repeat from data layout transformations.
dc2bcb0
@AndraBisca @github-actions
Update lib/Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp
afa59fe 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@abisca
Merge branch 'main' of https://github.com/Xilinx/mlir-aie into comput…
ebaeaef 
…e-tile-repeat
@hunhoffe
Can see error with test.cpp locally; try redirecting stderr to stdout…
44a240f 
… to see if I can see error in CI
@hunhoffe
Fix discrepencies in test.cpp between distribute-repeat test and example
ae94b44
@hunhoffe
Fix discrepencies between test.cpp in simple_repeat test vs programmi…
a7b0d64 
…ng example
@hunhoffe
fix typo
46052e9
@hunhoffe
Deleted repeat from programming examples (this is replaced by test/np…
5ecaf9c 
…u-xrt/objectfifo_repeat); delete unused cmake files
@hunhoffe
Remove unused makefiles
b26795d
@abisca
Update READMEs
aafda43
@abisca
Fix test
5634023
@abisca
Merge branch 'main' of https://github.com/Xilinx/mlir-aie into comput…
532f016 
…e-tile-repeat
@AndraBisca
Merge branch 'main' into compute-tile-repeat
d4a8109
@abisca
Always use DMAs if repeat count is specified
636a0a0
@jgmelber
Merge branch 'main' into objfifo-init
9f0e033
@abisca
Documentation
a709362
@abisca
Merge branch 'compute-tile-repeat' of https://github.com/Xilinx/mlir-aie
085e7e2 
 into compute-tile-repeat
@abisca
Merge branch 'main' of https://github.com/Xilinx/mlir-aie into objfif…
002a9ae 
…o-init
@abisca
Update implementation to use an ArrayAttr for initValues
8eeb29e
abisca and others added 24 commits November 7, 2024 11:18
@abisca
Cleanup repeat with link. Add fixes to support repeat with init values.
5c358f5
@abisca
Create npu-xrt test for init values with repeat.
bb9f710
@abisca
Resolved conflicts
173d727
@abisca
Update test
5290f65
@abisca
Add Makefile for test
f4a8188
@AndraBisca @github-actions
Update lib/Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp
3e05355 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@AndraBisca @github-actions
Update lib/Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp
b9c3fd7 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@abisca
Fix test
8cce9ad
@abisca
Merge branch 'objfifo-init' of https://github.com/Xilinx/mlir-aie int…
3509f15 
…o objfifo-init
@abisca
Add vec_vec_add example with objfifo init
4361938
@AndraBisca @github-actions
Update test/npu-xrt/vec_vec_add_objfifo_init/aie2.py
9d97340 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@AndraBisca @github-actions
Update test/npu-xrt/vec_vec_add_objfifo_init/aie2.py
322185a 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@AndraBisca @github-actions
Update test/npu-xrt/vec_vec_add_objfifo_init/aie2.py
d09210b 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@AndraBisca @github-actions
Update test/npu-xrt/vec_vec_add_objfifo_init/aie2.py
102a603 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@abisca
Merge branch 'main' of https://github.com/Xilinx/mlir-aie into objfif…
08d0f2f 
…o-init
@abisca
Update tests
e669467
@abisca
Add repeat example with L2 stationary weights
5b86652
@AndraBisca @github-actions
Update test/npu-xrt/objectfifo_repeat/init_values_repeat/aie2.py
eff4930 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@AndraBisca @github-actions
Update test/npu-xrt/objectfifo_repeat/init_values_repeat/aie2.py
a98b1bc 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@abisca
Merge branch 'main' of https://github.com/Xilinx/mlir-aie into objfif…
6f2b732 
…o-init
@abisca
Merge branch 'objfifo-init' of https://github.com/Xilinx/mlir-aie int…
d4ddb46 
…o objfifo-init
@abisca
Fix flags in test
e33c8d2
@abisca
Remove lit test
71efe88
@AndraBisca
Merge branch 'main' into objfifo-init
c674919
@AndraBisca AndraBisca marked this pull request as ready for review November 13, 2024 00:42
@AndraBisca AndraBisca changed the title [WIP] Enable init values for Object FIFO Enable init values for Object FIFO Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenneuendorffer stephenneuendorffer Awaiting requested review from stephenneuendorffer stephenneuendorffer is a code owner

@jgmelber jgmelber Awaiting requested review from jgmelber jgmelber is a code owner

@fifield fifield Awaiting requested review from fifield fifield is a code owner

@jackl-xilinx jackl-xilinx Awaiting requested review from jackl-xilinx jackl-xilinx is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndraBisca @abisca @hunhoffe @jgmelber