Compile test_utils at build time, use it in more tests #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This compiles runtime_lib/test_lib/test_utils.cpp into a library during mlir-aie build just like test_library.cpp and use it to remove at least 30 copies of load_instr_sequence() from tests. Remove the %host_runtime_lib command substitution from test/lit.cfg.py and replace with %test_lib_flags and %test_utils_flags.
fifield
requested review from
AndraBisca,
stephenneuendorffer,
jgmelber and
jackl-xilinx
as code owners
pvasireddy-amd
pushed a commit
to pvasireddy-amd/mlir-aie
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime_lib/test_lib/test_utils.cppinto a library during mlir-aie build just liketest_library.cppand use it to remove at least 30 copies ofload_instr_sequence()from tests. And some number ofcheck_arg_file_existstoo.%host_runtime_libcommand substitution fromtest/lit.cfg.pyand replace with%test_lib_flagsand%test_utils_flags.