refactor chess interface #1775
Merged
refactor chess interface #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To properly support other architectures, we need to call xchesscc with --aiearch as a parameter. This makes it more awkward to used the chess-clang hack. It was always a hack anyway, so remove it and instead require users to pass "+Wclang,xir" when feeding LLVMIR to chess. Lastly, clean up a small issue where we really should be using chess-llvm-link to link together downgraded LLVMIR for chess, rather than mixing and matching our LLVM tools with chess tools.
fifield
reviewed
Sep 18, 2024
Comment on lines
+448
to
+451
| # The path below is cheating a bit since it refers directly to the AIE1 | ||
| # version of llvm-link, rather than calling the architecture-specific | ||
| # tool version. | ||
| opts.aietools_path + "/tps/lnx64/target/bin/LNa64bin/chess-llvm-link", |
There was a problem hiding this comment.
So it does not matter which version is used?
There was a problem hiding this comment.
The different synopsys versions are currently pretty close to one another, and 'HEAD' is diverging relatively quickly... This is at some level kicking the can down the road, but it's better than what we have.
keryell
reviewed
Sep 18, 2024
Comment on lines
518
to
+519
| elif self.opts.link: | ||
| await self.do_call(task, ["xchesscc_wrapper", aie_target.lower(), "+w", self.prepend_tmp("work"), "-c", "-d", "-f", "+P", "4", file_core_llvmir_chesslinked, "-o", file_core_obj]) | ||
| await self.do_call(task, ["xchesscc_wrapper", aie_target.lower(), "+w", self.prepend_tmp("work"), "-c", "-d", "+Wclang,-xir", "-f", file_core_llvmir_chesslinked, "-o", file_core_obj]) |
There was a problem hiding this comment.
While you are here you could add a comment about what these options do without having to dive into Synopsys documentation since it is pretty ad-hoc.
Actually this is repeated 3 times, so perhaps a function?
| # Carefully crafted path so that we can inject other scripts into the chess path, namely chess-clang | ||
| export PATH=$DIR:$AIETOOLS/bin/unwrapped/lnx64.o:$AIETOOLS/tps/lnx64/target/bin/LNa64bin | ||
| $UNWRAPPED_XCHESSCC -p me -C Release_LLVM -D__AIENGINE__ $EXTRA_DEFS -Y clang=$DIR/chess-clang -P $LIBDIR -d -f $@ | ||
| xchesscc --aiearch ${AIEARCH} -p me -C Release_LLVM -D__AIENGINE__ $EXTRA_DEFS -P $LIBDIR -d -f $@ |
There was a problem hiding this comment.
Adding some comments for simple mortals wanting to understand?
| # install too! | ||
| foreach(file ${FILES}) | ||
| install(PROGRAMS ${file} DESTINATION ${SCRIPT_INSTALL_PATH}) | ||
| endforeach() | ||
| endif() |
There was a problem hiding this comment.
Missing EOL.
Curious, this project has an .editorconfig stating
insert_final_newline = true
|
|
||
| TARGETVAR=TARGET_${TARGET}_LIBDIR | ||
| LIBDIR=${!TARGETVAR} | ||
| LIBDIR=${AIETOOLS}/data/${AIEARCH}/lib | ||
|
|
||
| DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To properly support other architectures, we need to call xchesscc with --aiearch as a parameter. This makes it more awkward to used the chess-clang hack. It was always a hack anyway, so remove it and instead require users to pass "+Wclang,xir" when feeding LLVMIR to chess.
Lastly, clean up a small issue where we really should be using chess-llvm-link to link together downgraded LLVMIR for chess, rather than mixing and matching our LLVM tools with chess tools.