Fall back routine when bank-aware allocation fails #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvasireddy-amd
changed the title
pvasireddy-amd
changed the title
pvasireddy-amd
requested review from
stephenneuendorffer,
jgmelber,
fifield,
jackl-xilinx and
denolf
as code owners
…or failure of tests
fifield
approved these changes
Sep 19, 2024
| for (auto tile : device.getOps<TileOp>()) { | ||
| if (auto res = simpleBankAwareAllocation(tile); res.failed()) | ||
| return signalPassFailure(); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
might want to warn or error here if clAllocScheme was given by user but unrecognized
| Option<"clBasicAlloc", "basic-alloc", "bool", /*default=*/"false", | ||
| "Flag to enable the basic sequential allocation scheme (not bank-aware)."> | ||
| Option<"clAllocScheme", "alloc-scheme", "std::string", /*default=*/"", | ||
| "Choose allocation scheme; possibilities: basic-sequential, bank-aware. By default, bank-aware is selected and if it fails, will fall back to basic-sequential scheme.">, |
There was a problem hiding this comment.
Could this be made to fit into ~80-100 columns?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds flags for the user to select the allocation scheme. When no allocation scheme is given, bank-aware allocation is selected as default and when it fails, sequential allocation is performed.