[AIE2] Alias Analysis using AddrSpace Info #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andcarminati
reviewed
Sep 2, 2024
andcarminati
reviewed
Sep 2, 2024
|
Hi @krishnamtibrewala, I think that 05ae54e can be moved to another PR. |
andcarminati
reviewed
Sep 2, 2024
andcarminati
reviewed
Sep 2, 2024
andcarminati
reviewed
Sep 2, 2024
Does it cause errors in QoR? If so, are they caused by erroneous bank annotations? |
Yes, since it can potential error in QoR due to erroneous bank annotations. |
have moved the commit to PR #179 |
krishnamtibrewala
force-pushed
the
aie-AS-alias
branch
from
decda4b
to
82380e2
Compare
|
As a suggestion, we can have PR just for [AIE2] Refactor address space code. In this way we will keep this PR smaller. |
krishnamtibrewala
force-pushed
the
aie-AS-alias
branch
from
82380e2
to
7c9cda7
Compare
krishnamtibrewala
requested review from
abhinay-anubola,
abnikant,
gbossu,
khallouh,
konstantinschwarz,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
krishnamtibrewala
force-pushed
the
aie-AS-alias
branch
from
7c9cda7
to
71597e9
Compare
krishnamtibrewala
force-pushed
the
aie-AS-alias
branch
from
71597e9
to
43f5bab
Compare
krishnamtibrewala
force-pushed
the
aie-AS-alias
branch
from
43f5bab
to
f48189f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work is guarded under an option
--aie-alias-analysis-addrspace.Note : There are no QoR gain with this work!!