[AIE2] Enable LDA to use optimal itinerary #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnamtibrewala
force-pushed
the
aie2-LDA-var-itin
branch
from
0eb289c
to
55c85de
Compare
krishnamtibrewala
requested review from
abhinay-anubola,
abnikant,
andcarminati,
gbossu,
khallouh,
konstantinschwarz,
martien-de-jong,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
krishnamtibrewala
force-pushed
the
aie2-LDA-var-itin
branch
3 times, most recently
from
935c6ca
to
ce9e492
Compare
krishnamtibrewala
force-pushed
the
aie2-LDA-var-itin
branch
from
ce9e492
to
004f54e
Compare
krishnamtibrewala
force-pushed
the
aie2-LDA-var-itin
branch
2 times, most recently
from
12cc4fc
to
447d883
Compare
gbossu
reviewed
Sep 20, 2024
llvm/include/llvm/Target/Target.td
Outdated
| @@ -583,11 +583,15 @@ class EncodingByHwMode<list<HwMode> Ms = [], list<InstructionEncoding> Ts = []> | |||
| list<InstructionEncoding> Objects = Ts; | |||
| } | |||
|
|
|||
| class OperandRegClass<int OperIdx, RegisterClass Reg> { | |||
There was a problem hiding this comment.
Note: I think this should rather be in llvm/Target/AIETarget.td
There was a problem hiding this comment.
We needed list<ItinRegClassPair> as part of class Instruction thus we needed this to be added to Target.td
There was a problem hiding this comment.
We probably could have included Target.td in AIETarget.td
krishnamtibrewala
force-pushed
the
aie2-LDA-var-itin
branch
from
447d883
to
84db0ef
Compare
gbossu
reviewed
Sep 27, 2024
gbossu
reviewed
Sep 27, 2024
krishnamtibrewala
force-pushed
the
aie2-LDA-var-itin
branch
from
84db0ef
to
8614bbd
Compare
gbossu
reviewed
Sep 29, 2024
… load to use II_LDA_R
…partWord load to use II_LDA_1D_R
…s, partWord postinc load_2d to use II_LDA_2D_R
…s, partWord postinc load_3d to use II_LDA_3D_R
krishnamtibrewala
force-pushed
the
aie2-LDA-var-itin
branch
from
8614bbd
to
dc18e80
Compare
gbossu
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable LDA , and PostInc. Load with various addr mode to use optimal itinerary