Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stuckmann.waw.register.renaming #168

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Stuckmann.waw.register.renaming #168

merged 5 commits into from
Oct 4, 2024

Conversation

F-Stuckmann
Copy link
Collaborator

This PR renames registers in loops that have a WAW dependency. Thus it aims to increase scheduling freedom for software pipelining.

@F-Stuckmann F-Stuckmann marked this pull request as ready for review August 26, 2024 12:43
qcolombet
qcolombet reviewed Sep 25, 2024
View reviewed changes
Copy link

@qcolombet qcolombet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments here and there but looks good to me!

@F-Stuckmann
Copy link
Collaborator Author

incorporated Quentins comments

qcolombet
qcolombet reviewed Sep 26, 2024
View reviewed changes
Copy link

@qcolombet qcolombet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks even more good to me :).
(Not sure it is appropriate for me to approve, so I leave it at that :))

@F-Stuckmann F-Stuckmann force-pushed the stuckmann.waw.register.renaming branch 2 times, most recently from 79adf88 to 1829125 Compare September 27, 2024 08:49
@F-Stuckmann F-Stuckmann force-pushed the stuckmann.waw.register.renaming branch 2 times, most recently from 6f05e8b to 9a110fc Compare October 2, 2024 12:51
gbossu
gbossu previously approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@gbossu gbossu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and great work! That really wasn't an easy piece of code to write 💪

@F-Stuckmann F-Stuckmann force-pushed the stuckmann.waw.register.renaming branch from 9a110fc to 0454c58 Compare October 4, 2024 07:50
@F-Stuckmann
Copy link
Collaborator Author

fixed the conflicts

@gbossu gbossu mentioned this pull request Oct 4, 2024
Merged
@F-Stuckmann F-Stuckmann force-pushed the stuckmann.waw.register.renaming branch from 0454c58 to bc41f95 Compare October 4, 2024 08:58
@F-Stuckmann F-Stuckmann merged commit 4a65ca1 into aie-public Oct 4, 2024
8 checks passed
@gbossu gbossu mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martien-de-jong martien-de-jong martien-de-jong left review comments

@andcarminati andcarminati andcarminati left review comments

@qcolombet qcolombet qcolombet left review comments

@gbossu gbossu gbossu approved these changes

@abhinay-anubola abhinay-anubola Awaiting requested review from abhinay-anubola abhinay-anubola is a code owner

@abnikant abnikant Awaiting requested review from abnikant abnikant is a code owner

@khallouh khallouh Awaiting requested review from khallouh khallouh is a code owner

@konstantinschwarz konstantinschwarz Awaiting requested review from konstantinschwarz konstantinschwarz is a code owner

@SagarMaheshwari99 SagarMaheshwari99 Awaiting requested review from SagarMaheshwari99 SagarMaheshwari99 is a code owner

@stephenneuendorffer stephenneuendorffer Awaiting requested review from stephenneuendorffer stephenneuendorffer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@F-Stuckmann @qcolombet @andcarminati @gbossu @martien-de-jong