Prevent "too many nested groupings" xcode crash on undo #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test menu can be found in |
Turns out if it's not a printable key, it doesn't trigger the handler for grouping.
|
Thanks @squarefrog. Test has been added. That test fails with "exception raised" without the fix. |
|
To expand on the new change, the test showed that it works just fine for any type of replace. I was throwing the baby out with the bathwater with my initial fix, but it's only for newlines that it crashed on, so I handle that specific case instead. |
|
👍 glad you were able to narrow down the fix! |
This was referenced May 13, 2016
|
I am cherry-picking changes from #770 and adding tests (and fixing the edge cases mentioned). To save on hassle, how do I get the tests to see the updated code without having to restart Xcode every time? |
|
Closing in favor of #960 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When 954f200 was introduced, I don't think it accounted for the fact that the undo handlers would get triggers for
ras well asR, which I believe resulted in #817 being reported.I unfortunately was not able to test. I added
set debugto my config, restarted Xcode many times, and looked all over the menu forXVim -> Run Testbut didn't see anything. I'd be more than happy if someone who can run the tests could piggyback on this PR and write a test and run it on my behalf.Thanks!