[DO NOT MERGE] Amendment XLS-34d

.vscode/settings.json

@@ -12,9 +12,11 @@
         "altnet",
         "asyncio",
         "binarycodec",
+        "isnumeric",
         "nftoken",
         "rippletest",
         "ripplex",
-        "xaddress"
+        "xaddress",
+        "xchain"
     ],
 }

CHANGELOG.md

@@ -11,12 +11,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Created function alias to `safe_sign_and_autofill_transaction` called `autofill_and_sign` to reflect order of operations
 - Created function alias to `submit_transaction` called `submit`
 - Created function alias to `safe_sign_and_submit_transaction` called `sign_and_submit`
+- Support for cross-chain bridge proposal
 
 ### Changed:
 - `check_fee` now has a higher limit that is less likely to be hit
 - When connected to nft devnet or hooks v2 testnet generate_faucet_wallet now defaults to using the faucet instead of requiring specification
 - Deprecated `get_account_info`, `get_transaction_from_hash`, `get_account_payment_transactions` for direct requests
 - Private function `request_impl` has been renamed to `_request_impl`. Users should always use `request` over `request_impl`.
+- Support for cross-chain bridge proposal
+- New AMM API signature changes
 
 ### Fixed:
 - Properly type the instance functions of NestedModel
@@ -29,8 +32,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Function to parse the final account balances from a transaction's metadata
 - Function to parse order book changes from a transaction's metadata
 - Support for Ed25519 seeds that don't use the `sEd` prefix
+- Support for cross-chain bridge proposal
+- Support for Automated Market Maker (AMM) transactions and requests as defined in XLS-30.
 - Add docs to`get_account_transactions` explaining how to allow pagination through all transaction history [#462]
 - Common field `ticket_sequence` to Transaction class
+- Support for cross-chain bridge proposal
 
 ### Fixed:
 - Typing for factory classmethods on models

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "xrpl-py"
-version = "1.7.0"
+version = "1.9.0-beta.0"
 description = "A complete Python library for interacting with the XRP ledger"
 readme = "README.md"
 repository = "https://github.com/XRPLF/xrpl-py"

tests/unit/core/binarycodec/test_main.py

@@ -331,14 +331,14 @@ def test_xaddress_xaddr_and_matching_source_tag(self):
 
 
 class TestMainFixtures(TestCase):
-    maxDiff = 1000
+    maxDiff = None
 
     def _check_binary_and_json(self, test):
         test_binary = test["binary"]
         test_json = test["json"]
         with self.subTest(test_binary=test_binary, test_json=test_json):
-            self.assertEqual(encode(test_json), test_binary)
             self.assertEqual(decode(test_binary), test_json)
+            self.assertEqual(encode(test_json), test_binary)
 
     def _check_xaddress_jsons(self, test):
         x_json = test["xjson"]
@@ -390,14 +390,32 @@ def test_single_signing(self):
         )
         self.assertEqual(encode_for_signing(signing_json), expected)
 
-    def test_claim(self):
+    def test_native_claim(self):
         channel = "43904CBFCDCEC530B4037871F86EE90BF799DF8D2E0EA564BC8A3F332E4F5FB1"
         amount = "1000"
         json = {"amount": amount, "channel": channel}
 
         expected = (
-            "434C4D0043904CBFCDCEC530B4037871F86EE90BF799DF8D2E0EA564BC8A3F332E"
-            "4F5FB100000000000003E8"
+            "434C4D00"
+            "43904CBFCDCEC530B4037871F86EE90BF799DF8D2E0EA564BC8A3F332E4F5FB1"
+            "00000000000003E8"
+        )
+        self.assertEqual(encode_for_signing_claim(json), expected)
+
+    def test_ic_claim(self):
+        channel = "43904CBFCDCEC530B4037871F86EE90BF799DF8D2E0EA564BC8A3F332E4F5FB1"
+        amount = {
+            "issuer": "rJZdUusLDtY9NEsGea7ijqhVrXv98rYBYN",
+            "currency": "USD",
+            "value": "10",
+        }
+        json = {"amount": amount, "channel": channel}
+
+        expected = (
+            "434C4D00"
+            "43904CBFCDCEC530B4037871F86EE90BF799DF8D2E0EA564BC8A3F332E4F5FB1"
+            "D4C38D7EA4C680000000000000000000000000005553440000000000C0A5ABEF"
+            "242802EFED4B041E8F2D4A8CC86AE3D1"
         )
         self.assertEqual(encode_for_signing_claim(json), expected)
 

tests/unit/models/requests/test_amm_info.py

@@ -0,0 +1,16 @@
+from unittest import TestCase
+
+from xrpl.models.currencies.issue import Issue
+from xrpl.models.requests import AMMInfo
+
+_ASSET = Issue(currency="XRP")
+_ASSET_2 = Issue(currency="USD", issuer="rN6zcSynkRnf8zcgTVrRL8K7r4ovE7J4Zj")
+
+
+class TestAMMInfo(TestCase):
+    def test_asset_asset2(self):
+        request = AMMInfo(
+            asset=_ASSET,
+            asset2=_ASSET_2,
+        )
+        self.assertTrue(request.is_valid())