[DO NOT MERGE] Amendment XLS-34d #514
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangell7
changed the title
mvadari
reviewed
Feb 8, 2023
mvadari
reviewed
Feb 13, 2023
mvadari
reviewed
Feb 13, 2023
mvadari
reviewed
Feb 13, 2023
mvadari
reviewed
Feb 15, 2023
mvadari
reviewed
Feb 15, 2023
update fund wallet update authorize/verify add definitions change order of operation revert: add paychan to reusable values update: encode claim + test fund wallet add tests update xrp to amount
dangell7
force-pushed
the
denis-iouescrow
branch
from
76d19ed
to
fc51476
Compare
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Adding functionality for IOUEscrow Amendment
Context of Change
Amount- string -> AmountAmount- string -> AmountI also added an Issue Currency function on the setup client. This issues a currency for the wallet & destination.
I removed the PAYCHANNEL from the reusable and moved it into the test. (synergy)
Type of Change
Before / After
XRP ONLY for Payment Channel & Escrow / IOU/XRP for Payment Channel & Escrow
Test Plan
Please review the tests and let me know if you see more. There are much more tests in the rippled library. We can definitely adopt them.
I would like to discuss the gateway setup and having access to an issued token in each test suite.
Resources:
pip3 install git+https://github.com/Transia-RnD/xrpl-py.git@denis-iouescrow