Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Null safety #828

Closed
wants to merge 186 commits into from
Closed

WIP: Null safety #828

wants to merge 186 commits into from

Commits on Feb 4, 2021

  1. Widen analyzer dependency range to fix dev channel builds

    @aaronlademann-wf
    aaronlademann-wf committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    3b25e84 View commit details
    Browse the repository at this point in the history

  2. Move git diff check to its own step

    @aaronlademann-wf
    aaronlademann-wf committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    155d73e View commit details
    Browse the repository at this point in the history

  3. Try adding comments to speed up dev build?

    @aaronlademann-wf
    aaronlademann-wf committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    e8305c4 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. Remove build_web_compilers/build_modules overrides 

    + Now that there are tagged releases that work with 2.12 and analyzer 0.40.x
    @aaronlademann-wf
    aaronlademann-wf committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    800a9fc View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Copy dart version comment in generated parts

    @aaronlademann-wf
    aaronlademann-wf committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    8f3a081 View commit details
    Browse the repository at this point in the history

  2. Let the consumer know we don’t support this ish yet

    @aaronlademann-wf
    aaronlademann-wf committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    fb6d7ce View commit details
    Browse the repository at this point in the history

Commits on May 20, 2021

  1. Merge branch 'master' of github.com:Workiva/over_react into widen-ana… 

    …lyzer-range
    @aaronlademann-wf
    aaronlademann-wf committed May 20, 2021
    Configuration menu
    Copy the full SHA
    5b31e99 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'widen-analyzer-range' into null-unsafe-compat-builder

    @aaronlademann-wf
    aaronlademann-wf committed May 20, 2021
    Configuration menu
    Copy the full SHA
    570b422 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. Prep for null-safety

    @greglittlefield-wf
    greglittlefield-wf committed May 28, 2021
    Configuration menu
    Copy the full SHA
    ad10b8b View commit details
    Browse the repository at this point in the history

  2. Generate files

    @greglittlefield-wf
    greglittlefield-wf committed May 28, 2021
    Configuration menu
    Copy the full SHA
    15cb823 View commit details
    Browse the repository at this point in the history

  3. Add some hints

    @greglittlefield-wf
    greglittlefield-wf committed May 28, 2021
    Configuration menu
    Copy the full SHA
    e6aece8 View commit details
    Browse the repository at this point in the history

  4. Clean up some code to be easier to make null-safe

    @greglittlefield-wf
    greglittlefield-wf committed May 28, 2021
    Configuration menu
    Copy the full SHA
    c317210 View commit details
    Browse the repository at this point in the history

  5. Use null safety tool to migrate most non-builder code in lib, adding … 

    …hints but not applying the migration

Also excludes:
- lib/src/component
- lib/src/over_react_redux/devtools/
- lib/src/over_react_redux/over_react_flux.dart
    @greglittlefield-wf
    greglittlefield-wf committed May 28, 2021
    Configuration menu
    Copy the full SHA
    ceaebc9 View commit details
    Browse the repository at this point in the history

  6. More migration hints in core lib/src/component files

    @greglittlefield-wf
    greglittlefield-wf committed May 28, 2021
    Configuration menu
    Copy the full SHA
    8057181 View commit details
    Browse the repository at this point in the history

  7. Convert builder to be null-safe (minus using null safe deps like anal… 

    …yzer)
    @greglittlefield-wf
    greglittlefield-wf committed May 28, 2021
    Configuration menu
    Copy the full SHA
    2b748f4 View commit details
    Browse the repository at this point in the history

  8. Fix hints

    @greglittlefield-wf
    greglittlefield-wf committed May 28, 2021
    Configuration menu
    Copy the full SHA
    8d905e1 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. Upgrade to latest analyzer

    @greglittlefield-wf
    greglittlefield-wf committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    09be6c8 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. Remove BuiltReduxUiComponent and related built_redux APIs

    @greglittlefield-wf
    greglittlefield-wf committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    78afd8b View commit details
    Browse the repository at this point in the history

  2. Fix unnecessary ReactElement cast lints

    @greglittlefield-wf
    greglittlefield-wf committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    64f2a42 View commit details
    Browse the repository at this point in the history

  3. Don't reference removed forwardRef

    @greglittlefield-wf
    greglittlefield-wf committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    1e7b574 View commit details
    Browse the repository at this point in the history

  4. Fix misc lints

    @greglittlefield-wf
    greglittlefield-wf committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    3f5846d View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. Remove dart2_constant dependency

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    3114e3b View commit details
    Browse the repository at this point in the history

  2. Point to null safety transformer utils branch

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    f830756 View commit details
    Browse the repository at this point in the history

  3. Upgrade all dependencies to null safe releases except for w_common/w_… 

    …flux/over_react_test
    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    0ddfc25 View commit details
    Browse the repository at this point in the history

  4. Fix analysis errors after upgrading dependencies

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    f2f827a View commit details
    Browse the repository at this point in the history

  5. Apply migration (Dart 2.13.3)

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    1687b64 View commit details
    Browse the repository at this point in the history

  6. Fix analysis errors in builder after running migration

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    909a57f View commit details
    Browse the repository at this point in the history

  7. Fix warnings in builder after running migration

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    ad08ea2 View commit details
    Browse the repository at this point in the history

  8. Fix lints in builder after running migration

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    2da1db8 View commit details
    Browse the repository at this point in the history

  9. Remove conflicting extensions declared in package:collection

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    191cbb5 View commit details
    Browse the repository at this point in the history

  10. Fix errors in builder tests

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    a726eea View commit details
    Browse the repository at this point in the history

  11. Fix lots of unnecessary null-aware warnings

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    7c78411 View commit details
    Browse the repository at this point in the history

  12. Fix remaining warnings in builder tests

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    7960c07 View commit details
    Browse the repository at this point in the history

  13. Add missing null check

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    2d44d59 View commit details
    Browse the repository at this point in the history

  14. Remove build configs for remove dependencies

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    b6f1564 View commit details
    Browse the repository at this point in the history

  15. Fix syntax error in component_base.dart

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    d5898bd View commit details
    Browse the repository at this point in the history

  16. Fix DummyComponent2 implementation

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    cd91e96 View commit details
    Browse the repository at this point in the history

  17. Update builder to emit correct nullability in generated code

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    22871ca View commit details
    Browse the repository at this point in the history

  18. Update generated code

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    0f9bfb8 View commit details
    Browse the repository at this point in the history

  19. Add missing late

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    1ef30bd View commit details
    Browse the repository at this point in the history

  20. Update generated code 

    fixup
    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    f325b38 View commit details
    Browse the repository at this point in the history

  21. Fix overrides in component_base

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    256f593 View commit details
    Browse the repository at this point in the history

  22. Attempt to fix nullability issues in component_declaration and util

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    617df73 View commit details
    Browse the repository at this point in the history

  23. Fix nullability issues in internal components

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    54f1c8f View commit details
    Browse the repository at this point in the history

  24. Generate code

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    0374035 View commit details
    Browse the repository at this point in the history

  25. Fix syntax error in test

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    1c93705 View commit details
    Browse the repository at this point in the history

  26. Fix Redux nullability issues

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    9795e89 View commit details
    Browse the repository at this point in the history

  27. Fix bad casts added by tool

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    45491fe View commit details
    Browse the repository at this point in the history

  28. Tweak nullability on prop key utils

    @greglittlefield-wf
    greglittlefield-wf committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    8356f21 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2021

  1. Properly convert CSSValue parsing to null safety

    @greglittlefield-wf
    greglittlefield-wf committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    10ad6c2 View commit details
    Browse the repository at this point in the history

  2. Fix null and null-aware warnings

    @greglittlefield-wf
    greglittlefield-wf committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    b1f2669 View commit details
    Browse the repository at this point in the history

  3. Fix incorrect null safety conversions

    @greglittlefield-wf
    greglittlefield-wf committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    de928f1 View commit details
    Browse the repository at this point in the history

  4. Clean up null checks

    @greglittlefield-wf
    greglittlefield-wf committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    eec4a99 View commit details
    Browse the repository at this point in the history

  5. Fix nullability in Component2

    @greglittlefield-wf
    greglittlefield-wf committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    b24969d View commit details
    Browse the repository at this point in the history

  6. Null check cleanup

    @greglittlefield-wf
    greglittlefield-wf committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    8785b15 View commit details
    Browse the repository at this point in the history

  7. Fix InfluxStoreMixin nullability

    @greglittlefield-wf
    greglittlefield-wf committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    7ace186 View commit details
    Browse the repository at this point in the history

  8. Use runZonedGuarded instead of deprecated runZoned

    @greglittlefield-wf
    greglittlefield-wf committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    869d2ac View commit details
    Browse the repository at this point in the history

  9. Add more hasher test cases to support refactoring

    @greglittlefield-wf
    greglittlefield-wf committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    6239714 View commit details
    Browse the repository at this point in the history

  10. Fix a bunch of small nullability errors/warnings/lints

    @greglittlefield-wf
    greglittlefield-wf committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    a84e48a View commit details
    Browse the repository at this point in the history

  11. Fix incorrect nullability

    @greglittlefield-wf
    greglittlefield-wf committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    607097c View commit details
    Browse the repository at this point in the history

  12. Remove unused meta imports

    @greglittlefield-wf
    greglittlefield-wf committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    3152bd6 View commit details
    Browse the repository at this point in the history

  13. Fix disposable method migration

    @greglittlefield-wf
    greglittlefield-wf committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    46d2c07 View commit details
    Browse the repository at this point in the history

  14. Make getProps/getDartComponent dynamic so that consumers don't need t… 

    …o do any casting to Object
    @greglittlefield-wf
    greglittlefield-wf committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    2a341aa View commit details
    Browse the repository at this point in the history

  15. Clean up react wrappers tests

    @greglittlefield-wf
    greglittlefield-wf committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    8240478 View commit details
    Browse the repository at this point in the history

  16. Add missing not-null-assertions

    @greglittlefield-wf
    greglittlefield-wf committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    7273755 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Merge remote-tracking branch 'origin/master' into null-safety

    @greglittlefield-wf
    greglittlefield-wf committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    a436845 View commit details
    Browse the repository at this point in the history

  2. Fix builder analysis errors after master merge

    @greglittlefield-wf
    greglittlefield-wf committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    c23a399 View commit details
    Browse the repository at this point in the history

  3. Upgrade changes from master to null safety, misc fixes after merge

    @greglittlefield-wf
    greglittlefield-wf committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    6225af6 View commit details
    Browse the repository at this point in the history

  4. Re-generate over_react parts

    @greglittlefield-wf
    greglittlefield-wf committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    44731dc View commit details
    Browse the repository at this point in the history

  5. Update mockito mocks

    @greglittlefield-wf
    greglittlefield-wf committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    a6a897f View commit details
    Browse the repository at this point in the history

  6. More misc null safety error fixes

    @greglittlefield-wf
    greglittlefield-wf committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    8c13e2d View commit details
    Browse the repository at this point in the history

  7. Fix lints related to type checking

    @greglittlefield-wf
    greglittlefield-wf committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    353f5d4 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Remove unnecessary casts

    @greglittlefield-wf
    greglittlefield-wf committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    19a8475 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Add null-checks for non-nullable props, add nullability example

    @greglittlefield-wf
    greglittlefield-wf committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    51d5964 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Conditionally generate null safe code (not using pubspec constraint yet)

    @greglittlefield-wf
    greglittlefield-wf committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    7fe5a1e View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2023

  1. Null-safe props: fix null checks / null awares

    @greglittlefield-wf
    greglittlefield-wf committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    ebec2f2 View commit details
    Browse the repository at this point in the history

  2. Attempt to improve migrator tool inference when encountering generate… 

    …d accessors
    @greglittlefield-wf
    greglittlefield-wf committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    d4851ed View commit details
    Browse the repository at this point in the history

  3. Factor late-ness into prop requiredness metadata

    @greglittlefield-wf
    greglittlefield-wf committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    9ba7c46 View commit details
    Browse the repository at this point in the history

  4. Use uiJsComponent where possible so that we can benefit from props cl… 

    …ass codegen

This makes it so we don't have to manually override all the
@toBeGenerated members in builder_helpers.UiProps, which we
apparently forgot to do.
    @greglittlefield-wf
    greglittlefield-wf committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    561f66d View commit details
    Browse the repository at this point in the history

  5. Use defaults when possible in accessor generation

    @greglittlefield-wf
    greglittlefield-wf committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    5ef8f6b View commit details
    Browse the repository at this point in the history

  6. Re-enable null safety in builder

    @greglittlefield-wf
    greglittlefield-wf committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    541601f View commit details
    Browse the repository at this point in the history

  7. Re-generate with null-safe parts and updated accessors

    @greglittlefield-wf
    greglittlefield-wf committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    c49db91 View commit details
    Browse the repository at this point in the history

  8. Default to null-safe builder output only for over_react for the time … 

    …being
    @greglittlefield-wf
    greglittlefield-wf committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    5686fb0 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Add proof-of-concept for new required prop validation

    @greglittlefield-wf
    greglittlefield-wf committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    08a52d4 View commit details
    Browse the repository at this point in the history

  2. Missing required prop diagnostic: clean up, add support for late

    @greglittlefield-wf
    greglittlefield-wf committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    9cb3308 View commit details
    Browse the repository at this point in the history

  3. Add support for accessing non-nullable props in getPropKey, handle no… 

    …n-operator[] reads
    @greglittlefield-wf
    greglittlefield-wf committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    5a0a454 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Merge branch 'master' into null-safety 

    # Conflicts:
#	pubspec.yaml
    @hunterbreathat-wk
    hunterbreathat-wk committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    812289c View commit details
    Browse the repository at this point in the history

  2. Update deps

    @hunterbreathat-wk
    hunterbreathat-wk committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    c42570a View commit details
    Browse the repository at this point in the history

  3. Update deps

    @hunterbreathat-wk
    hunterbreathat-wk committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    307ffc1 View commit details
    Browse the repository at this point in the history

  4. Update deps

    @hunterbreathat-wk
    hunterbreathat-wk committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    11a9074 View commit details
    Browse the repository at this point in the history

  5. Update deps....

    @hunterbreathat-wk
    hunterbreathat-wk committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    4135ecb View commit details
    Browse the repository at this point in the history

  6. Update deps....

    @hunterbreathat-wk
    hunterbreathat-wk committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    5b4760f View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Tweak workflow, move dependency_validator config

    @hunterbreathat-wk
    hunterbreathat-wk committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    09a986f View commit details
    Browse the repository at this point in the history

  2. Bump min to 2.18.7

    @hunterbreathat-wk
    hunterbreathat-wk committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    03be47a View commit details
    Browse the repository at this point in the history

  3. Tweaking pubspec

    @hunterbreathat-wk
    hunterbreathat-wk committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    800e38f View commit details
    Browse the repository at this point in the history

  4. Resolve dependency issues

    @hunterbreathat-wk
    hunterbreathat-wk committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    1441d03 View commit details
    Browse the repository at this point in the history

  5. Resolve dependency issues

    @hunterbreathat-wk
    hunterbreathat-wk committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    f3bf23e View commit details
    Browse the repository at this point in the history

  6. Fix dart_dependency_validator

    @hunterbreathat-wk
    hunterbreathat-wk committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    98130a8 View commit details
    Browse the repository at this point in the history

  7. Tweaks to react version and remove null safe check

    @hunterbreathat-wk
    hunterbreathat-wk committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    4b7f25b View commit details
    Browse the repository at this point in the history

  8. (Test) Changes related to core lib

    @hunterbreathat-wk
    hunterbreathat-wk committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    010d5a2 View commit details
    Browse the repository at this point in the history

  9. (Test) Misc remaining fixes

    @hunterbreathat-wk
    hunterbreathat-wk committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    0d33b34 View commit details
    Browse the repository at this point in the history

  10. (Test) Fix temp override

    @hunterbreathat-wk
    hunterbreathat-wk committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    aeb4111 View commit details
    Browse the repository at this point in the history

  11. (Test) Fix analyzer warning

    @hunterbreathat-wk
    hunterbreathat-wk committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    551be17 View commit details
    Browse the repository at this point in the history

  12. (Test) Fix analyzer warning...

    @hunterbreathat-wk
    hunterbreathat-wk committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    b8df980 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Update react-dart null safety branch, adjust errors and ref typings

    @greglittlefield-wf
    greglittlefield-wf committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    efc89c7 View commit details
    Browse the repository at this point in the history

  2. Clean up casts and nullability in getProps

    @greglittlefield-wf
    greglittlefield-wf committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    e1ace93 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Disable spike validateRequiredProps implementation

    @greglittlefield-wf
    greglittlefield-wf committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    cff04d5 View commit details
    Browse the repository at this point in the history

  2. Fix casts to non-nullable values, enable lint

    @greglittlefield-wf
    greglittlefield-wf committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    fa13972 View commit details
    Browse the repository at this point in the history

  3. Commit generated code

    @greglittlefield-wf
    greglittlefield-wf committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    6ce859d View commit details
    Browse the repository at this point in the history

  4. Fix CssValue.parse handling of non-finite num values

    @greglittlefield-wf
    greglittlefield-wf committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    bbe7a77 View commit details
    Browse the repository at this point in the history

  5. Fix bad casts in AbstractTransition tests

    @greglittlefield-wf
    greglittlefield-wf committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    f01a402 View commit details
    Browse the repository at this point in the history

  6. Remove function casts added by migrator tool that are either incorrec… 

    …t or unnecessary
    @greglittlefield-wf
    greglittlefield-wf committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    f4cd005 View commit details
    Browse the repository at this point in the history

  7. Fix errors after removing casts

    @greglittlefield-wf
    greglittlefield-wf committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    9287ee5 View commit details
    Browse the repository at this point in the history

  8. Fix nullability of flux actions in test fixture and examples

    @greglittlefield-wf
    greglittlefield-wf committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    84f954c View commit details
    Browse the repository at this point in the history

  9. Fix some typing in prop conversion and its tests

    @greglittlefield-wf
    greglittlefield-wf committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    44e2466 View commit details
    Browse the repository at this point in the history

  10. Revert dummy_component2 changes, add note about why it's generated

    @greglittlefield-wf
    greglittlefield-wf committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    809d427 View commit details
    Browse the repository at this point in the history

  11. Check in forgotten dummy_component2 generated file

    @greglittlefield-wf
    greglittlefield-wf committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    fd4d839 View commit details
    Browse the repository at this point in the history

  12. Update getPropKey tests to reflect new implementation

    @greglittlefield-wf
    greglittlefield-wf committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    371c05c View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Fix more tests

    @greglittlefield-wf
    greglittlefield-wf committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    a51b2cf View commit details
    Browse the repository at this point in the history

  2. Sync ref APIs with react-dart, update usages

    @greglittlefield-wf
    greglittlefield-wf committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    2ed7a1a View commit details
    Browse the repository at this point in the history

  3. Fix cast_nullable_to_non_nullable warnings in tests

    @greglittlefield-wf
    greglittlefield-wf committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    825895e View commit details
    Browse the repository at this point in the history

  4. Remove unused import

    @greglittlefield-wf
    greglittlefield-wf committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    cf345d4 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Fix remaining cast_nullable_to_non_nullable warnings

    @greglittlefield-wf
    greglittlefield-wf committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    a174582 View commit details
    Browse the repository at this point in the history

  2. Fix broken propTypes due to out-of-sync JS wrapper with incorrect arg… 

    …ument types

Replace with a super-call so that we can reuse react-dart's implementation.
    @greglittlefield-wf
    greglittlefield-wf committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    57e0e1f View commit details
    Browse the repository at this point in the history

  3. Fix connect not working with null state, use type alias

    @greglittlefield-wf
    greglittlefield-wf committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    26553dc View commit details
    Browse the repository at this point in the history

  4. Clean up noisy test output

    @greglittlefield-wf
    greglittlefield-wf committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    4ffbee7 View commit details
    Browse the repository at this point in the history

  5. Clean up noisy test output

    @greglittlefield-wf
    greglittlefield-wf committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    b5ea8e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Upgrade Dockerfile Dart version

    @greglittlefield-wf
    greglittlefield-wf committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    ab0ade7 View commit details
    Browse the repository at this point in the history

  2. Upgrade Dockerfile Dart version

    @greglittlefield-wf
    greglittlefield-wf committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    3848103 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Update Component2Bridge call with new nullability

    @greglittlefield-wf
    greglittlefield-wf committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    b28c80e View commit details
    Browse the repository at this point in the history

  2. Fix getDebugNameForDartComponent

    @greglittlefield-wf
    greglittlefield-wf committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    2039a4e View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Reinstate ?? null in generated accessors until we work around the u… 

    …ndefined bug in JsBackedMap
    @greglittlefield-wf
    greglittlefield-wf committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    1d4262a View commit details
    Browse the repository at this point in the history

  2. Update generated code

    @greglittlefield-wf
    greglittlefield-wf committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    db6e6e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Merge remote-tracking branch 'origin/master' into null-safety 

    Also migrate new consumed props APIs to null safety
    @greglittlefield-wf
    greglittlefield-wf committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    31ec0ab View commit details
    Browse the repository at this point in the history

  2. Update generated code

    @greglittlefield-wf
    greglittlefield-wf committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    6b755e8 View commit details
    Browse the repository at this point in the history

  3. Remove dart_dev override, re-enable dart_dev

    @greglittlefield-wf
    greglittlefield-wf committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    09bb9e7 View commit details
    Browse the repository at this point in the history

  4. Remove unused built_redux dependency

    @greglittlefield-wf
    greglittlefield-wf committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    c4f62fd View commit details
    Browse the repository at this point in the history

  5. Clean up nullabilities

    @greglittlefield-wf
    greglittlefield-wf committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    ec4bca4 View commit details
    Browse the repository at this point in the history

  6. Clean up import

    @greglittlefield-wf
    greglittlefield-wf committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    c06c231 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'prepare-for-react-dart-v7' into null-safety

    @greglittlefield-wf
    greglittlefield-wf committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    4254fe4 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Clean up nullability in builder code

    @greglittlefield-wf
    greglittlefield-wf committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    e772873 View commit details
    Browse the repository at this point in the history

  2. Fix typing of firstWhereType

    @greglittlefield-wf
    greglittlefield-wf committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    5f3ccf6 View commit details
    Browse the repository at this point in the history

  3. Clean up non-null assertions on codegen fields sourceFile/outputConte… 

    …ntsBuffer/logger
    @greglittlefield-wf
    greglittlefield-wf committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    1f699b8 View commit details
    Browse the repository at this point in the history

  4. Clean up nullability

    @greglittlefield-wf
    greglittlefield-wf committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    da70d64 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Update MissingRequiredProp after upgrading to analyzer 5

    @greglittlefield-wf
    greglittlefield-wf committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    7ee39a5 View commit details
    Browse the repository at this point in the history

  2. Clean up analyzer_plugin ignores now that the over_react builder is n… 

    …ull-safe
    @greglittlefield-wf
    greglittlefield-wf committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c6ac61a View commit details
    Browse the repository at this point in the history

  3. Migrate test and tool entry points to null safety

    @greglittlefield-wf
    greglittlefield-wf committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b01e498 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Re-enable diagnostics that imported non-null-safe builder code

    @greglittlefield-wf
    greglittlefield-wf committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    52573f1 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into null-safety

    @greglittlefield-wf
    greglittlefield-wf committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    e688b3f View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Update react-dart branch

    @greglittlefield-wf
    greglittlefield-wf committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    a78586e View commit details
    Browse the repository at this point in the history

  2. Reenable type overrides since tests currently expect them

    @greglittlefield-wf
    greglittlefield-wf committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    c7d94ff View commit details
    Browse the repository at this point in the history

  3. Conditionally output Accessor arguments to match old generation

    @greglittlefield-wf
    greglittlefield-wf committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    510f294 View commit details
    Browse the repository at this point in the history

  4. Opt existing test cases with gold files out of null safe generation

    @greglittlefield-wf
    greglittlefield-wf committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    5fa0d13 View commit details
    Browse the repository at this point in the history

  5. Fix inverted boolean typo

    @greglittlefield-wf
    greglittlefield-wf committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    ccc0b84 View commit details
    Browse the repository at this point in the history

  6. Fix accidentally removed annotationCount++

    @greglittlefield-wf
    greglittlefield-wf committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    4c0f4e7 View commit details
    Browse the repository at this point in the history

  7. Update generated code after PropDescriptor argument changes

    @greglittlefield-wf
    greglittlefield-wf committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    16bb496 View commit details
    Browse the repository at this point in the history

  8. Update generated code after restoring types in accessor overrides

    @greglittlefield-wf
    greglittlefield-wf committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    903a8b1 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Clean up null safety in redux dev tools middleware

    @greglittlefield-wf
    greglittlefield-wf committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    406432e View commit details
    Browse the repository at this point in the history

  2. Clean up spike implementations, update FIXMEs

    @greglittlefield-wf
    greglittlefield-wf committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    bf4d91d View commit details
    Browse the repository at this point in the history

  3. Point to released react

    @greglittlefield-wf
    greglittlefield-wf committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    6f20410 View commit details
    Browse the repository at this point in the history

  4. Clean up non-null assertion operators

    @greglittlefield-wf
    greglittlefield-wf committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    e7e0069 View commit details
    Browse the repository at this point in the history

  5. Clean up nullable iterable check

    @greglittlefield-wf
    greglittlefield-wf committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    f98bbfa View commit details
    Browse the repository at this point in the history

  6. Make dom/aria helpers late final

    @greglittlefield-wf
    greglittlefield-wf committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    c86e202 View commit details
    Browse the repository at this point in the history

  7. Fix generic parameter nullability

    @greglittlefield-wf
    greglittlefield-wf committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    222bbea View commit details
    Browse the repository at this point in the history

  8. Make cloneElement argument non-nullable

    @greglittlefield-wf
    greglittlefield-wf committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    fdf11a3 View commit details
    Browse the repository at this point in the history

  9. Fix weird casting

    @greglittlefield-wf
    greglittlefield-wf committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    8541686 View commit details
    Browse the repository at this point in the history

  10. Make TActions arguments in connect callbacks not nullable

    @greglittlefield-wf
    greglittlefield-wf committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    cf2148c View commit details
    Browse the repository at this point in the history

  11. Get on null-safe w_flux, update Action usages

    @greglittlefield-wf
    greglittlefield-wf committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    118b145 View commit details
    Browse the repository at this point in the history

  12. Clean up missing required prop spike

    @greglittlefield-wf
    greglittlefield-wf committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    97e6216 View commit details
    Browse the repository at this point in the history

  13. Remove outdated FIXME

    @greglittlefield-wf
    greglittlefield-wf committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    5952428 View commit details
    Browse the repository at this point in the history

  14. Clean up required props validation spike code

    @greglittlefield-wf
    greglittlefield-wf committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    2780838 View commit details
    Browse the repository at this point in the history

  15. Clean up example / test Action class nullability

    @greglittlefield-wf
    greglittlefield-wf committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    fbc30d4 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Clean up LHS types added by migrator

    @greglittlefield-wf
    greglittlefield-wf committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    7132160 View commit details
    Browse the repository at this point in the history

  2. Clean up nullability in examples

    @greglittlefield-wf
    greglittlefield-wf committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    3939b10 View commit details
    Browse the repository at this point in the history

  3. Clean up validateRequiredProps more

    @greglittlefield-wf
    greglittlefield-wf committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    b47f2e3 View commit details
    Browse the repository at this point in the history

  4. Revert accidental changes

    @greglittlefield-wf
    greglittlefield-wf committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    5779ef9 View commit details
    Browse the repository at this point in the history

  5. Remove bad cast

    @greglittlefield-wf
    greglittlefield-wf committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    0e5145b View commit details
    Browse the repository at this point in the history

  6. Clean up closest impl, make more optimal, null-safe

    @greglittlefield-wf
    greglittlefield-wf committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    199feb4 View commit details
    Browse the repository at this point in the history

  7. Clean up empty lines from language version comments

    @greglittlefield-wf
    greglittlefield-wf committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    9644fb4 View commit details
    Browse the repository at this point in the history

  8. Revert ReactElement return types made nullable by migrator

    @greglittlefield-wf
    greglittlefield-wf committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    f987644 View commit details
    Browse the repository at this point in the history

  9. Remove unnecessary ReactElement typings added by migrator

    @greglittlefield-wf
    greglittlefield-wf committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    8057d39 View commit details
    Browse the repository at this point in the history

  10. Clean up SafeRenderManager tests nullability

    @greglittlefield-wf
    greglittlefield-wf committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    71a2dc5 View commit details
    Browse the repository at this point in the history

  11. Clean up unnecessary LHS function types added by migrator

    @greglittlefield-wf
    greglittlefield-wf committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    f5879d1 View commit details
    Browse the repository at this point in the history

  12. Fix handler chaining nullability

    @greglittlefield-wf
    greglittlefield-wf committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    2ee5ba9 View commit details
    Browse the repository at this point in the history

  13. Add WIP 5.0.0 changelog entry

    @greglittlefield-wf
    greglittlefield-wf committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    fab842c View commit details
    Browse the repository at this point in the history

  14. Merge remote-tracking branch 'origin/master' into null-safety

    @greglittlefield-wf
    greglittlefield-wf committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    dcf2bca View commit details
    Browse the repository at this point in the history