Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Null safety #828

Closed
wants to merge 186 commits into from
Closed

WIP: Null safety #828

wants to merge 186 commits into from

Conversation

hunterbreathat-wk
Copy link
Contributor

Motivation

Changes

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

aaronlademann-wf and others added 30 commits February 4, 2021 16:01
@aaronlademann-wf
Widen analyzer dependency range to fix dev channel builds
3b25e84
@aaronlademann-wf
Move git diff check to its own step
155d73e
@aaronlademann-wf
Try adding comments to speed up dev build?
e8305c4
@aaronlademann-wf
Remove build_web_compilers/build_modules overrides
800a9fc 
+ Now that there are tagged releases that work with 2.12 and analyzer 0.40.x
@aaronlademann-wf
Copy dart version comment in generated parts
8f3a081
@aaronlademann-wf
Let the consumer know we don’t support this ish yet
fb6d7ce
@aaronlademann-wf
Merge branch 'master' of github.com:Workiva/over_react into widen-ana…
5b31e99 
…lyzer-range
@aaronlademann-wf
Merge branch 'widen-analyzer-range' into null-unsafe-compat-builder
570b422
@greglittlefield-wf
Prep for null-safety
ad10b8b
@greglittlefield-wf
Generate files
15cb823
@greglittlefield-wf
Add some hints
e6aece8
@greglittlefield-wf
Clean up some code to be easier to make null-safe
c317210
@greglittlefield-wf
Use null safety tool to migrate most non-builder code in lib, adding …
ceaebc9 
…hints but not applying the migration

Also excludes:
- lib/src/component
- lib/src/over_react_redux/devtools/
- lib/src/over_react_redux/over_react_flux.dart
@greglittlefield-wf
More migration hints in core lib/src/component files
8057181
@greglittlefield-wf
Convert builder to be null-safe (minus using null safe deps like anal…
2b748f4 
…yzer)
@greglittlefield-wf
Fix hints
8d905e1
@greglittlefield-wf
Upgrade to latest analyzer
09be6c8
@greglittlefield-wf
Remove BuiltReduxUiComponent and related built_redux APIs
78afd8b
@greglittlefield-wf
Fix unnecessary ReactElement cast lints
64f2a42
@greglittlefield-wf
Don't reference removed forwardRef
1e7b574
@greglittlefield-wf
Fix misc lints
3f5846d
@greglittlefield-wf
Remove dart2_constant dependency
3114e3b
@greglittlefield-wf
Point to null safety transformer utils branch
f830756
@greglittlefield-wf
Upgrade all dependencies to null safe releases except for w_common/w_…
0ddfc25 
…flux/over_react_test
@greglittlefield-wf
Fix analysis errors after upgrading dependencies
f2f827a
@greglittlefield-wf
Apply migration (Dart 2.13.3)
1687b64
@greglittlefield-wf
Fix analysis errors in builder after running migration
909a57f
@greglittlefield-wf
Fix warnings in builder after running migration
ad08ea2
@greglittlefield-wf
Fix lints in builder after running migration
2da1db8
@greglittlefield-wf
Remove conflicting extensions declared in package:collection
191cbb5
@greglittlefield-wf
Clean up null safety in redux dev tools middleware
406432e
@greglittlefield-wf
Clean up spike implementations, update FIXMEs
bf4d91d
@greglittlefield-wf
Point to released react
6f20410
@greglittlefield-wf
Clean up non-null assertion operators
e7e0069
@greglittlefield-wf
Clean up nullable iterable check
f98bbfa
@greglittlefield-wf
Make dom/aria helpers late final
c86e202
@greglittlefield-wf
Fix generic parameter nullability
222bbea
@greglittlefield-wf
Make cloneElement argument non-nullable
fdf11a3
@greglittlefield-wf
Fix weird casting
8541686
@greglittlefield-wf
Make TActions arguments in connect callbacks not nullable
cf2148c
@greglittlefield-wf
Get on null-safe w_flux, update Action usages
118b145
@greglittlefield-wf
Clean up missing required prop spike
97e6216
@greglittlefield-wf
Remove outdated FIXME
5952428
@greglittlefield-wf
Clean up required props validation spike code
2780838
@greglittlefield-wf
Clean up example / test Action class nullability
fbc30d4
@greglittlefield-wf
Clean up LHS types added by migrator
7132160
@greglittlefield-wf
Clean up nullability in examples
3939b10
@greglittlefield-wf
Clean up validateRequiredProps more
b47f2e3
@greglittlefield-wf
Revert accidental changes
5779ef9
@greglittlefield-wf
Remove bad cast
0e5145b
@greglittlefield-wf
Clean up closest impl, make more optimal, null-safe
199feb4
@greglittlefield-wf
Clean up empty lines from language version comments
9644fb4
@greglittlefield-wf
Revert ReactElement return types made nullable by migrator
f987644
@greglittlefield-wf
Remove unnecessary ReactElement typings added by migrator
8057d39
@greglittlefield-wf
Clean up SafeRenderManager tests nullability
71a2dc5
@greglittlefield-wf
Clean up unnecessary LHS function types added by migrator
f5879d1
@greglittlefield-wf
Fix handler chaining nullability
2ee5ba9
@greglittlefield-wf
Add WIP 5.0.0 changelog entry
fab842c
@greglittlefield-wf
Merge remote-tracking branch 'origin/master' into null-safety
dcf2bca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Merge Requirements Unmet Skynet 2.0 Failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hunterbreathat-wk @aviary-wf @greglittlefield-wf @rmconsole-wf @aaronlademann-wf