Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Menu: Localize "No Parent" and menu item labels in nav menu options #7788

Closed
wants to merge 5 commits into from
Closed

Nav Menu: Localize "No Parent" and menu item labels in nav menu options #7788

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fda66fa
Nav Menu: Localize "No Parent" and menu item labels in nav menu options
yogeshbhutkar Nov 13, 2024
e8c39a6
Nav Menu: Enhance localization for "No Parent" and menu item labels i…
yogeshbhutkar Nov 18, 2024
877c74e
Nav Menu: Improve option label formatting using sprintf for better lo…
yogeshbhutkar Nov 19, 2024
af0dfcc
Nav Menu: Add translator comments for menu and submenu item numbering
yogeshbhutkar Nov 19, 2024
426cadc
Assign new strings to variables for improved readability.
joedolson Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/js/_enqueues/lib/nav-menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@
$selected = 'selected';
}

$html += '<option ' + $selected + ' value="0">No Parent</option>';
$html += '<option ' + $selected + ' value="0">' + wp.i18n._x( 'No Parent', 'menu item without a parent in navigation menu' ) + '</option>';

$.each( menuItems, function() {
var menuItem = $(this),
Expand Down Expand Up @@ -364,7 +364,13 @@
if ( i == itemPosition ) {
$selected = 'selected';
}
$html += '<option ' + $selected + ' value="' + i + '">' + i + ' of ' + totalMenuItems + '</option>';
// Translators: %1$s is the current menu item number, %2$s is the total number of menu items.
var itemString = wp.i18n.sprintf(
wp.i18n._x( '%1$s of %2$s', 'indicating a part of a total number of items in a navigation menu' ),
i,
totalMenuItems
);
$html += '<option ' + $selected + ' value="' + i + '">' + itemString + '</option>';
}

} else {
Expand All @@ -380,7 +386,13 @@
if ( i == itemPosition ) {
$selected = 'selected';
}
$html += '<option ' + $selected + ' value="' + i + '">' + i + ' of ' + totalSubMenuItems + '</option>';
// Translators: %1$s is the current submenu item number, %2$s is the total number of submenu items.
var submenuString = wp.i18n.sprintf(
wp.i18n._x( '%1$s of %2$s', 'indicating a part of a total number of items in a submenu' ),
i,
totalSubMenuItems
);
$html += '<option ' + $selected + ' value="' + i + '">' + submenuString + '</option>';
}

}
Expand Down
Loading