-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nav Menu: Localize "No Parent" and menu item labels in nav menu options #7788
Nav Menu: Localize "No Parent" and menu item labels in nav menu options #7788
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the two of
strings use wp.i18n._x
instead of wp.i18n.__
to provide additional context to translators? It may not be clear what is being translated.
…n navigation options
Thanks, @desrosj for suggesting an improvement here. Sure, it would be better to provide context to the translator. I've added a patch for the same. Thanks. |
@yogeshbhutkar one more change! @SergeyBiryukov confirmed in track that |
Thanks, @desrosj. The changes are appended to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a change purely for readability, but otherwise this is good to go.
Description
Updated raw strings to use i18n functions.
Trac ticket: https://core.trac.wordpress.org/ticket/62402
Screenshot of the fix:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.