Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some 5xx error code handling for function #5014

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Added some 5xx error code handling for function #5014

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f86c55f
added some 5xx error code handling for function
MarleaM Sep 29, 2024
5a1e47b
Fixed trailing whitespace error.
MarleaM Oct 1, 2024
2941d17
trying to fix the ruff issue
MarleaM Oct 2, 2024
0c644b4
Ran with ruff
MarleaM Oct 3, 2024
b7104c7
Revert "Ran with ruff"
stacimc Oct 9, 2024
bba00e3
Lint
stacimc Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions catalog/dags/providers/provider_api_scripts/stocksnap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
import json
import logging

import backoff
from requests.exceptions import HTTPError

from common.licenses import get_license_info
from common.loader import provider_details as prov
from providers.provider_api_scripts.provider_data_ingester import ProviderDataIngester
Expand Down Expand Up @@ -157,6 +160,17 @@ def _get_title(item):
img_title = " ".join(tags)
return img_title.title()

# Add a backoff on every request
# for 5XX error codes.
# See: https://github.com/WordPress/openverse/issues/4878
@backoff.on_exception(
backoff.expo,
HTTPError,
# 30 minutes
max_time=60 * 30,
# Only retry for 5xx errors
giveup=lambda e: e.response.status_code not in {502, 503, 504},
)
def _get_filesize(self, image_url):
"""Get the size of the image in bytes."""
resp = self.delayed_requester.head(image_url)
Expand Down