-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added some 5xx error code handling for function #5014
Conversation
So sorry, but I'm not too sure how to get my lint check to pass. If anyone has any advice, it would be greatly appreciated! Thanks |
Based on the contributor urgency of this PR, the following reviewers are being gently reminded to review this PR: @krysal Excluding weekend1 days, this PR was ready for review 5 day(s) ago. PRs labelled with contributor urgency are expected to be reviewed within 3 weekday(s)2. @MarleaM, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
This reverts commit 0c644b4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @MarleaM! And apologies about the delay to review. I've pushed the linting changes that were needed and tested stocksnap locally; looks good to me! In the future, however, we ask that you create a feature branch rather than opening a PR from the main
branch of your fork.
If you're still having trouble with ov
in your environment, do you mind creating a new issue with more details so we can take a look? Thanks!
* added some 5xx error code handling for function * Fixed trailing whitespace error. * trying to fix the ruff issue * Ran with ruff * Revert "Ran with ruff" This reverts commit 0c644b4. * Lint --------- Co-authored-by: Staci Cooper <[email protected]>
Fixes
Fixes #4878 by @AetherUnbound
Description
Fix for when we encounter ephemeral 5XX errors with certain Stocksnap errors. Added a backoff.on_exception wrapper to the _get_filesize function of the ingestion class.
I was unable to test this fix. However, Docker compiled successfully.
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin