Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some 5xx error code handling for function #5014

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Conversation

MarleaM
Copy link
Contributor

@MarleaM MarleaM commented Oct 1, 2024

Fixes

Fixes #4878 by @AetherUnbound

Description

Fix for when we encounter ephemeral 5XX errors with certain Stocksnap errors. Added a backoff.on_exception wrapper to the _get_filesize function of the ingestion class.

I was unable to test this fix. However, Docker compiled successfully.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@MarleaM MarleaM requested a review from a team as a code owner October 1, 2024 19:03
@MarleaM MarleaM requested review from krysal and stacimc and removed request for a team October 1, 2024 19:03
@openverse-bot openverse-bot added 🧱 stack: catalog Related to the catalog and Airflow DAGs 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Oct 1, 2024
@MarleaM MarleaM requested a review from a team as a code owner October 3, 2024 17:04
@MarleaM
Copy link
Contributor Author

MarleaM commented Oct 3, 2024

So sorry, but I'm not too sure how to get my lint check to pass. If anyone has any advice, it would be greatly appreciated! Thanks

@openverse-bot
Copy link
Collaborator

Based on the contributor urgency of this PR, the following reviewers are being gently reminded to review this PR:

@krysal
@stacimc
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend1 days, this PR was ready for review 5 day(s) ago. PRs labelled with contributor urgency are expected to be reviewed within 3 weekday(s)2.

@MarleaM, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

  1. Specifically, Saturday and Sunday.

  2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the operation that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range.

Copy link
Collaborator

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @MarleaM! And apologies about the delay to review. I've pushed the linting changes that were needed and tested stocksnap locally; looks good to me! In the future, however, we ask that you create a feature branch rather than opening a PR from the main branch of your fork.

If you're still having trouble with ov in your environment, do you mind creating a new issue with more details so we can take a look? Thanks!

@stacimc stacimc merged commit 04f0060 into WordPress:main Oct 9, 2024
46 checks passed
Danil49 pushed a commit to Danil49/openverse that referenced this pull request Oct 29, 2024
* added some 5xx error code handling for function

* Fixed trailing whitespace error.

* trying to fix the ruff issue

* Ran with ruff

* Revert "Ran with ruff"

This reverts commit 0c644b4.

* Lint

---------

Co-authored-by: Staci Cooper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add backoff to Stocksnap DAG for 5XX errors
3 participants