Don't automatically select blocks when entering zoom out #61433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -119 B (-0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
scruffian
force-pushed
the
try/dont-select-blocks
branch
from
1e32b15 to
cdbd466
Compare
scruffian
changed the title
draganescu
reviewed
May 8, 2024
There was a problem hiding this comment.
I think moving selection from a block to the containing section when engaging zoom out enhances the assembling experience, but selecting the bottom of the document is disorientating and serves no purpose since appending is the default if there is no selection.
| dispatch.selectBlock( lastSectionClientId ); | ||
| } | ||
| } else { | ||
| dispatch.selectBlock( lastSectionClientId ); |
There was a problem hiding this comment.
I think we should remove only this branch
| ); | ||
| dispatch.selectBlock( rootClientId ); | ||
| } else { | ||
| // If there's no block selected and no sectionRootClientId, select the last root block. |
|
Let's close in favour of #61484 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Now that we have a section root client id set, we should remove this code that selects a block.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast