Zoom out: show patterns when clearing block selection #61428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +54 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
scruffian
reviewed
May 7, 2024
| let sectionRootClientId; | ||
|
|
||
| if ( __unstableGetEditorMode() === 'zoom-out' ) { | ||
| sectionRootClientId = unlock( |
There was a problem hiding this comment.
I wonder if we should do this earlier - in usePatternCategories, or even in InserterMenu?
There was a problem hiding this comment.
I think doing it here in usePatternsState is fine - we're already using the blockEditorStore here so I don't think it feels too late. I looked at doing it earlier and it felt kind of out of place in usePatternCategories, InserterMenu, and BlockPatternsTab - it seems to require more code as we're not already calling the store in these files.
There was a problem hiding this comment.
I wonder if actually we want to create a new selector for this, so we can access it in different places.
|
Should we revert changes from #61002 if/when we land this? |
|
Closing in favour of #61464 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
When in zoom out mode, and no block is selected, the block editing mode for the root is disabled, so we need to use the section root instead. Patterns should be inserted at the "section root", not the root of the document.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast