-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Update separator block's expected HTML in UI tests #39636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit, the expected HTML for the separator block is updated to reflect recent changes from #38428. This is done so that the tests pass as expected.
Size Change: 0 B Total Size: 1.21 MB ℹ️ View Unchanged
|
hypest
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Separator
Affects the Separator Block
Mobile App - Automation
Label used to initiate Mobile App PR Automation
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
Gutenberg Mobile:
[RNMobile] Update separator block's expected HTML in automated tests wordpress-mobile/gutenberg-mobile#4679What?
This PR updates the separator block's expected HTML in the block insertion UI test (part 2).
Why?
The separator block's HTML was updated following changes in #38428. Following this update, the block insertion UI tests began to fail here, due to the change to the expected HTML.
How?
The block's new
has-alpha-channel-opacity
class has been added to the expected HTML in the tests. This is in line with updates to the tests on the web-side, as shown in the code changes in #38428, for example here.Testing Instructions
npm run native test:e2e:ios:local
andnpm run native test:e2e:android:local
to verify the UI tests pass (specificallyGutenberg Editor tests for Block insertion 2
).gutenberg-mobile
PR: [RNMobile] Update separator block's expected HTML in automated tests wordpress-mobile/gutenberg-mobile#4679