Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Integration test] Separator block #4681

Closed
SiobhyB opened this issue Mar 22, 2022 · 2 comments
Closed

[Integration test] Separator block #4681

SiobhyB opened this issue Mar 22, 2022 · 2 comments
Labels
Integration test Testing Anything related to automated tests

Comments

@SiobhyB
Copy link
Contributor

SiobhyB commented Mar 22, 2022 •
edited
Loading

The separator block was recently refactored in WordPress/gutenberg#38428, which led to some "false positive" failures in the block insertion UI test (part 2). These failures were addressed in WordPress/gutenberg#39636.

As it looks like there will be further changes to the separator block in the future, it'd be valuable to add integration tests to catch issues like these before code's merged.
@SiobhyB SiobhyB added Integration test Testing Anything related to automated tests labels Mar 22, 2022
@SiobhyB SiobhyB changed the title [Integration Test] Separator block [Integration test] Separator block Mar 22, 2022
@SiobhyB SiobhyB self-assigned this Jun 22, 2022
@geriux
Copy link
Contributor

geriux commented Dec 30, 2022

We recently added an integration test for this block in WordPress/gutenberg#46583 should we close this issue?

@SiobhyB SiobhyB removed their assignment Jan 3, 2023
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jan 3, 2023

@geriux, great, thanks! I'll go ahead to close this. :)

@SiobhyB SiobhyB closed this as completed Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Integration test Testing Anything related to automated tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SiobhyB @geriux