Site Editor: Highlight list view blocks when canvas blocks are hovered #29103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeyip
requested review from
vindl,
mattwiebe,
Addison-Stavlo and
david-szabo97
jeyip
commented
Feb 18, 2021
There was a problem hiding this comment.
There are a lot of wrinkles with the code, and this definitely isn't a final draft of what we'll deliver (See To-dos in the PR description). Looking for more general feedback on the approach and if this is what you had in mind @Copons
|
Size Change: +60 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
I've been mulling over this for a long time, and I'm still not exactly sure if this is the right way to go. My doubt can be boiled down to: what's the difference between "highlight" and "hover"? On a technical level, the highlight is tracked with Redux, while the hover is handled via internal state (via hook, but that's irrelevant). In this PR (and in my initial experiment as well), we are setting a block highlighted on hover, which in turn means that hovering on a block will make it both hovered and highlighted. Do we need both states? I've got a draft (#29005) that moves the block hover state to Redux, basically mirroring the highlight behaviour. Besides the question about highlight/hover, I also wonder if dispatching on every mouseover and mouseout might be a performance issue. 🤔 |
Completely agree with posing this question. I had some confusion while coding out this PR, but couldn't quite verbalize what was "off". Gonna give this more thought 🤔
👍
Yep! Noted it in the PR description -- it's a concern for me as well. I don't have any great answers yet. |
|
Closing this PR in favor of Jacopo's similar draft #29005 (although, as discussed, we might go a different route altogether) |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See the GIF below for more context.
How has this been tested?
Screenshots
To-dos
highlightBlocksOnHoverpropTypes of changes
New feature that addresses #28699 and builds on top of #28637
Checklist: