Update/site editor list view block hover #29005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +171 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
Copons
changed the base branch from
master
to
add/fse-persistent-block-navigator
Copons
force-pushed
the
add/fse-persistent-block-navigator
branch
from
e7fa1de to
f4b986b
Compare
Copons
changed the base branch from
add/fse-persistent-block-navigator
to
master
Copons
changed the base branch from
master
to
add/fse-persistent-block-navigator
Copons
force-pushed
the
add/fse-persistent-block-navigator
branch
from
f4b986b to
40bb7ee
Compare
Copons
force-pushed
the
update/site-editor-list-view-block-hover
branch
from
cc1950f to
4574b84
Compare
7 tasks
|
Continuing the discussion from here #29103 (comment)
I spent some time mucking around with debouncing and implementing mouseenter alongside mouseout to explore how much more performant we could make the interactions (not much) |
|
@jeyip Thanks for moving the convo here! I'm sorry I didn't surface this PR sooner to avoid the duplication, but I kinda thought I was working on this alone... 😄 I'll ping some designers that may have some insights regarding the hover/highlight distinction: @shaunandrews @jameskoster @mtias |
|
I think we should generally use the "highlight" in these operations. (I used it for hovering/focusing on the parent block selector in the toolbar, and I think should be the exact same for the list view.) The other hover we have is meant to be used as a visual artefact (gray instead of blue) when just moving across the canvas. I think it should be restricted to that effect and don't be part of the redux store. |
@mtias To give some context to the issue at hand: the main Persistent List View PR (#28637) already uses the highlight to... highlight blocks when hovering on the List View items. In this PR we are figuring out how to do the opposite: highlight the List View item when hovering the block. There are three options, as far as I can see, and I'm not convinced by any of them. 😅
The way I see it, hover and highlight serve a very similar purpose, and their major difference is how they are triggered (mouseover or Redux action). |
|
Ah, yes, got it. I think we need to go with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
Screenshots
Types of changes
Checklist: