Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/block inserter headings #22902

Closed
wants to merge 2 commits into from
Closed

Update/block inserter headings #22902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5524834
Adds a heading to the block inserters tips (#22863)
Jun 4, 2020
7430d9e
Add semantic headings to block inserter groups #22859
Jun 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/block-editor/src/components/inserter/menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { includes } from 'lodash';
*/
import { useState } from '@wordpress/element';
import { LEFT, RIGHT, UP, DOWN, BACKSPACE, ENTER } from '@wordpress/keycodes';
import { TabPanel } from '@wordpress/components';
import { TabPanel, VisuallyHidden } from '@wordpress/components';
import { __ } from '@wordpress/i18n';
import { useSelect } from '@wordpress/data';

Expand Down Expand Up @@ -92,6 +92,11 @@ function InserterMenu( {
</div>
{ showInserterHelpPanel && (
<div className="block-editor-inserter__tips">
<VisuallyHidden>
<h2 className="block-editor-inserter__tips-title">
{ __( 'Tips for using the block editor:' ) }
</h2>
</VisuallyHidden>
<Tips />
</div>
) }
Expand Down
4 changes: 2 additions & 2 deletions packages/block-editor/src/components/inserter/panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ function InserterPanel( { title, icon, children } ) {
return (
<>
<div className="block-editor-inserter__panel-header">
<span className="block-editor-inserter__panel-title">
<h2 className="block-editor-inserter__panel-title">
{ title }
</span>
</h2>
<Icon icon={ icon } />
</div>
<div className="block-editor-inserter__panel-content">
Expand Down
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/inserter/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ $block-inserter-tabs-height: 44px;
text-transform: uppercase;
font-size: 11px;
font-weight: 500;
margin-right: $grid-unit-10;
margin: 0 $grid-unit-10 0 0;
}

.block-editor-inserter__block-list {
Expand Down