Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/block inserter headings #22902

Closed

Conversation

gaambo
Copy link
Contributor

@gaambo gaambo commented Jun 4, 2020

Description

Changes the headings of block groups from spans to h2 to provide a semantic structuring. Related to #22859

How has this been tested?

  • Open the block inserter - headings should look exactly as before the commit (same margin, font-size etc).
  • Should be tested with a screenreader?

Screenshots

grafik

Types of changes

Bug fix, css-class is the same as before and styling is the same.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@gaambo
Copy link
Contributor Author

gaambo commented Jun 4, 2020

sorry, used the wrong branch from a previous commit. gonna do it new based on master.

@gaambo gaambo closed this Jun 4, 2020
@gaambo gaambo deleted the update/block-inserter-headings branch June 4, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants