Allow {WINE,WINESERVER}_BIN env vars #2318
Merged
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to set `WINE_BIN` and `WINESERVER_BIN` using environment variables outside Winetricks. These affect binary bitness detection during startup. Winetricks performs a Wine binary bitness detection to print a warning. In some environments such as Protontricks and Nix, the Wine executables are wrappers that call binaries that are located elsewhere. In those situations we want to provide the path to the binary that's only used for the check to avoid printing unnecessary warnings. Closes: Winetricks#2183
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to set
WINE_BINandWINESERVER_BINusing environment variables outside Winetricks.Winetricks performs a Wine binary bitness detection to print a warning. In some environments, such as Protontricks and Nix, the Wine executable is a wrapper that calls a binary that's located elsewhere. In those situations we want to provide the path to the binary that's only used for the check to avoid printing unnecessary warnings.
Closes: #2183