Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WINE Binary Paths and WoW64 Arch Type Detect #383

Closed
alkaris2 opened this issue Jan 10, 2025 · 2 comments
Closed

Update WINE Binary Paths and WoW64 Arch Type Detect #383

alkaris2 opened this issue Jan 10, 2025 · 2 comments

Comments

@alkaris2
Copy link

Describe the bug
Referening a bug from Winetricks/winetricks#2183

When you start Protontricks it will complain it can't detect WoW64 type.
To fix it like in upstream of Winetricks, provide a WINESERVER_BIN and WINE_BIN path which should point to /usr/bin/ for the respective native binaries of Wine, by doing this will solve WoW64 type detection errors, and other known issues like Unknown file arch: 65 or warning: You are using a 64-bit WINEPREFIX. type messages.

On another note, it's easier to manage things when different Arch Types of Wine is used, for example a separate Wine 32 and Wine 64 prefix directories and to detect for these types of directory differences that someone may have setup by having a WINEPREFIX and WINEPREFIX_64 path as a general way to silence multiple warning popups when running Protontricks. These are common type warnings that really shouldn't be presented to the end user and bares no significance of the actual usability of Protontricks and are only seen as nuisance messages, and doesn't prevent anything from running like a typical error would by halting all execution when a serious problem is encountered.

System (please complete the following information):

  • Distro: Manjaro 24.2.1
  • Protontricks installation method: Pacman / AUR
  • Protontricks version: 1.12.0
  • Steam version: 1733265492 - Stable 64-bit
@Matoking
Copy link
Owner

Matoking commented Jan 12, 2025

Thanks for the reminder, that particular issue had slipped my mind over time.

The WINESERVER_BIN and WINE_BIN are always set and thus overridden by Winetricks, although ALL_CAPS naming indicates they should be analogous to environment variables. This is a trivial fix and I've submitted one upstream at Winetricks/winetricks#2318.

Matoking added a commit that referenced this issue Jan 12, 2025
Set `WINE_BIN` and `WINESERVER_BIN` when launching a Protontricks
command. Winetricks uses these to target specific files during the
"binary bitness" check; prior to this Winetricks would attempt to read
the wrapper scripts instead, causing spurious warnings to be printed.

Resolves #383
@Matoking
Copy link
Owner

The upstream Winetricks patch and Protontricks fix have been merged. Both have to be installed in order to disable the warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants