Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data rearchitecture] fix minor bug in UpdateTimeslicesCourseWiki #6188

Conversation

gabina
Copy link
Member

@gabina gabina commented Feb 10, 2025

What this PR does

This PR fixes a minor bug found in data-rearchitecture-for-dashboard instance. The error case was found when the course start date was changed to a previous date, without the course having any edit. Therefore, ingestion start date remained the same as course start, and the timeslice for that date had not yet been created when UpdateTimeslicesCourseWiki ran.

image

Open questions and concerns

< anything you learned that you want to share, or questions you're wondering about related to this PR >

…nd there is no timeslice for the start ingestion date
@gabina gabina marked this pull request as ready for review February 10, 2025 01:17
@gabina
Copy link
Member Author

gabina commented Feb 10, 2025

hmm HighQualityArticleMonitor specs are failing again.

Failures:

  1) HighQualityArticleMonitor.create_alerts_for_course_articles creates Alert records for edited Good articles
     Failure/Error: expect(HighQualityArticleAssignmentAlert.count).to eq(1)

       expected: 1
            got: 0

       (compared using ==)
     # ./spec/lib/alerts/high_quality_article_monitor_spec.rb:58:in `block (3 levels) in <top (required)>'

  2) HighQualityArticleMonitor.create_alerts_for_course_articles does create second Alert if the first alert is resolved and there are later assignments
     Failure/Error: expect(HighQualityArticleAssignmentAlert.count).to eq(2)

       expected: 2
            got: 1

       (compared using ==)
     # ./spec/lib/alerts/high_quality_article_monitor_spec.rb:128:in `block (3 levels) in <top (required)>'

@gabina gabina merged commit db4cf74 into WikiEducationFoundation:data-rearchitecture-for-dashboard Feb 10, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant