Fix minor bug in UpdateTimeslicesCourseWiki when start date changes a…

…nd there is no timeslice for the start ingestion date (#6188)
WikiEducationFoundation · Feb 10, 2025 · db4cf74 · db4cf74
1 parent e133aef
commit db4cf74
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/app/services/update_timeslices_course_wiki.rb b/app/services/update_timeslices_course_wiki.rb
@@ -52,6 +52,7 @@ def update_timeslices_durations
     @course.wikis.each do |wiki|
       start = @timeslice_manager.get_ingestion_start_time_for_wiki wiki
       timeslice = @course.course_wiki_timeslices.where(wiki:, start:).first
+      next unless timeslice
       effective_timeslice_duration = timeslice.end - timeslice.start
       real_timeslice_duration = @timeslice_manager.timeslice_duration(wiki)
       # Continue if timeslice duration didn't change for the wiki

diff --git a/spec/services/update_timeslices_course_wiki_spec.rb b/spec/services/update_timeslices_course_wiki_spec.rb
@@ -125,4 +125,10 @@
       expect(last_timeslice.end - last_timeslice.start).to eq(172800)
     end
   end
+
+  it 'doesnt fail if there are no timeslices for the ingestion start date' do
+    manager.create_timeslices_for_new_course_wiki_records([enwiki])
+    course.update(start: '2018-11-20')
+    described_class.new(course).run
+  end
 end