Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WDSUS-42 - Install ACF Pro as part of the theme. #54

Closed
wants to merge 15 commits into from
Closed

WDSUS-42 - Install ACF Pro as part of the theme. #54

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e283d7d
WDSUS-42 - Install ACF Pro as part of the theme.
khleomix Aug 21, 2023
717e3b1
WDSUS-42 - Update Readme
khleomix Aug 21, 2023
b799056
refactor block files, adding render for dynamic block
Sep 2, 2023
6942e52
file structure change due to refactor of render properties
Sep 2, 2023
5ac1feb
new block starter
Sep 2, 2023
3d2c96c
new WP-CLI file operations
Sep 2, 2023
89fb3e9
removed block operations from theme webpack
Sep 2, 2023
b88917f
build-blocks as new blocks output directory
Sep 2, 2023
bdca5fb
assigment not needed
Sep 2, 2023
5e90978
ACF is no longer required
Sep 2, 2023
3cab25b
add metadata when registering block
Sep 3, 2023
e01036d
code doc block explaning how to use ACF with this files
Sep 3, 2023
3886135
register block conditionally if ACF Pro is activated
Sep 3, 2023
992f091
conditional block registration based on ACF activation
Sep 3, 2023
580556f
the property we need to be override with ACF Pro is `render_callback`
Sep 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ Command | Action

### Building a block with wpcli

In order to build a block, run the following wpcli script.
In order to build a block, the ACF Pro plugin needs to be activated and then run the following wpcli script.

Note: If you're using Local, you can open the shell from within Local to do this. `Sitename -> Open site shell`.

Expand Down
14 changes: 14 additions & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,21 @@
},
"sort-packages": true
},
"repositories": [
{
"type": "composer",
"url": "https://packages.wdslab.com"
}
],
"extra": {
"installer-paths": {
"../../plugins/{$name}/": [
"type:wordpress-plugin"
]
}
},
"require": {
"wpengine/advanced-custom-fields-pro": "^6.0",
"composer/installers": "^1.5 || ^2.0.0",
"erusev/parsedown": "^1.7",
"erusev/parsedown-extra": "^0.8.1"
Expand Down
17 changes: 16 additions & 1 deletion composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading