WDSUS-42 - Install ACF Pro as part of the theme.

[khleomix]

Closes WDSUS-42

What type of PR is this? (put an x to all applicable)

• 🍕 Feature
• 🐛 Bug Fix
• 📝 Documentation Update
• 🎨 Style
• 🧑‍💻 Code Refactor
• 🔥 Performance Improvements
• ✅ Test
• 🤖 Build
• 🔁 CI
• 📦 Chore (Release)
• ⏩ Revert

Link to test

Test locally, run composer install inside the theme

Description

• Add ACF Pro plugin into the theme composer file, plugin will be installed when composer install is run. This makes sure that the plugin is installed since the Block WPCLI script is dependent on the plugin.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

N/A

Added tests?

• 👍 yes
• 🙅 no, because they aren't needed
• 🙋 no, because I need help

Added to documentation?

• 📜 README.md
• 📓 Confluence
• 🙅 no documentation needed

Others

• 🦮 Is this issue accessible? (Section 508/WCAG 2.0AA)
• 🙌 Does this issue pass all the linting? (PHPCS, ESLint, SassLint)

[optional] Are there any post-deployment tasks we need to perform?

[itsamoreh]

VIA slack:

This is a public theme, I don’t think we should be adding a package from packages.wdslab.com? Doesn’t that break the theme unless you have creds for our private repo? What do you think?

Is there any way we can add an error if ACF Pro isn’t installed instead? Or better yet, remove the dependency on ACF all together and make it optional? IMO the theme should not be dependent on any plugins.

[khleomix]

Closing this because we're going another way.