Hack: restrict CDI date selection for lag; COUNTRY=jordan #1326
+110
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/WFP-VAM/prism-app into feat/allow-flexible-season-validity
gislawill
changed the base branch from
master
to
feat/allow-flexible-season-validity
7 tasks
|
@wadhwamatic, please use this branch/surge deployment for your demo |
|
Build succeeded and deployed at https://prism-1326.surge.sh |
…-day-selection-for-lag
wadhwamatic
changed the title
|
Thanks @gislawill for setting this up. It looks like data on the hip-analysis is out of date though and the lag approach fails with begin 2024-05-21 and end date 2024-06-21. I'm not sure if @paololucchino is back and able to address the issue on the hip-analysis side. I'll try him.. |
There's a bug between the date fix in the CDI and the date restriction for forecasts. Removing forecasts for the purpose of this demo
|
@gislawill - I found a bug when toggling a forecast layer in this PR. It's yet another edge case for dates where we're limiting forecast data to only be available for today and forward. Don't worry about this for right now as this was a short-term solution for CDI anyway. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update addresses this request: #1259 (comment) and replaces #1295 (easier to use new branch rather than update the previous).
It applies the "earliestExpectedDataLagDays" logic across our default data selection and which dates are available to select.
In my opinion, this is probably not worth the effort to maintain — it's not intuitive and could easily result in future bugs. But we could always merge it has a hack and remove it once https://github.com/WFP-VAM/hip-service/issues/12 is ready.
How to test the feature:
Checklist - did you ...
Test your changes with
REACT_APP_COUNTRY=rbd yarn startREACT_APP_COUNTRY=cambodia yarn startREACT_APP_COUNTRY=mozambique yarn startScreenshot/video of feature:
https://www.loom.com/share/49e0769fd9b840d78a535d68c4cbf7da