Restricting the available days when data lags expected; COUNTRY=jordan #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded and deployed at https://prism-1295.surge.sh |
|
Converting to draft — only for use in demo |
gislawill
force-pushed
the
dynamic-error-cdi
branch
from
d902875
to
df5a171
Compare
7 tasks
7 tasks
|
Closing in favor of #1326 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update addresses this request: #1259 (comment)
It applies the "earliestExpectedDataLagDays" logic across our default data selection and which dates are available to select.
In my opinion, this is probably not worth the effort to maintain — it's not intuitive and could easily result in future bugs. But we could always merge it has a hack and remove it once https://github.com/WFP-VAM/hip-service/issues/12 is ready
How to test the feature:
Checklist - did you ...
Test your changes with
REACT_APP_COUNTRY=rbd yarn startREACT_APP_COUNTRY=cambodia yarn startREACT_APP_COUNTRY=mozambique yarn startScreenshot/video of feature: