Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Dropdown layer selection remains after selection; COUNTRY=jordan #1325

Conversation

gislawill
Copy link
Collaborator

Description

This fixes #1324 by returning layer with group from formatLayersCategories regardless of whether layer is frozen.

How to test the feature:

  • Load up Jordan
  • Toggle between monthly and seasonal CDI

Checklist - did you ...

Test your changes with

  • REACT_APP_COUNTRY=rbd yarn start
  • REACT_APP_COUNTRY=cambodia yarn start
  • REACT_APP_COUNTRY=mozambique yarn start
  • Add / update necessary tests?
  • Add / update outdated documentation?

Screenshot/video of feature:

Bug:
https://www.loom.com/share/9836aea706db463f958c47928f092ab2?sid=30bd8f75-206e-4ce2-b470-0489a168e8e6
Fix:
https://www.loom.com/share/5d8eaacc94b2426f922e3f3f58c19d47?sid=efb91ecc-a4f2-44eb-bb1e-c5a10e85f14d

Copy link

Build succeeded and deployed at https://prism-1325.surge.sh
(hash 5bd595b deployed at 2024-07-31T18:31:10)

@wadhwamatic
Copy link
Member

Looks good from my side @gislawill

@ericboucher
Copy link
Collaborator

@gislawill looks ok but I just want to make sure this would not undo the fix you did for #1301 (comment)

I was not able to test yet because the geonode server is down again

@gislawill
Copy link
Collaborator Author

@gislawill looks ok but I just want to make sure this would not undo the fix you did for #1301 (comment)

I was not able to test yet because the geonode server is down again

@ericboucher, that's correct. It does not undo the fix for #1301 (comment). Both updating the global layer definition (the fix in 52dbd65) is required for displaying groups like "Tropical Storms" in Mozambique and returning the layer with the group regardless of whether the update was allowed or not (the fix in 5bd595b) is required for this this layer dropdown to remain after a selection has been made.

Confirmed this morning that this group is still working as intended:
image

@ericboucher ericboucher merged commit 0d693ae into master Aug 2, 2024
6 checks passed
@ericboucher ericboucher deleted the 1324-bug-left-panel-group-dropdown-select-disappears-after-selection branch August 2, 2024 08:59
@ericboucher ericboucher restored the 1324-bug-left-panel-group-dropdown-select-disappears-after-selection branch August 2, 2024 11:48
@ericboucher ericboucher deleted the 1324-bug-left-panel-group-dropdown-select-disappears-after-selection branch August 2, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Left Panel group dropdown select disappears after selection
3 participants