Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[I18N][15.0] account: update vi_VN translation file #550

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from

Conversation

tuoi1501
Copy link

@tuoi1501 tuoi1501 commented Oct 5, 2022

Description of the issue/feature this PR addresses:
ticket: https://viindoo.com/web#id=7309&menu_id=89&model=helpdesk.ticket&view_type=form

Current behavior before PR:
Tại trường Payment Type:

  • Text Receive được dịch là Nhận
  • Text Send được dịch là Gửi

Desired behavior after PR is merged:

  • Text Receive được dịch lại thành Nhận tiền
  • Text Send được dịch là Chi tiền

Screenshot from 2022-11-09 11-48-26


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@viinbot viinbot added 🚀 Queue 🚀 Building 🚀 Running PR/Commit is done for everything and ready for manually test and removed 🚀 Queue 🚀 Building labels Oct 5, 2022
@viinbot viinbot added 🚩 Done PR/Commit is finished manually test and closed instance 🚀 Running PR/Commit is done for everything and ready for manually test and removed 🚀 Running PR/Commit is done for everything and ready for manually test 🚩 Done PR/Commit is finished manually test and closed instance labels Oct 12, 2022
@@ -11833,7 +11833,7 @@ msgstr "Lựa chọn"
#: model:ir.model.fields.selection,name:account.selection__account_payment__payment_type__outbound
#: model_terms:ir.ui.view,arch_db:account.account_invoice_send_wizard_form
msgid "Send"
msgstr "Gửi"
msgstr "Chi tiền"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Ở đây phần dịch sẽ bị ảnh hưởng đến 2 chỗ: giá trị của trường payment_type và string của nút Send and Print của wizard account_invoice_send_wizard_form.
  • Vì vậy mà em đã làm 1 PR để ghi đè string của nút Send and Print trong trường hợp string của nó là 'Send' để dịch lại cho đúng nghĩa: https://github.com/Viindoo/tvtmaaddons/pull/6926

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuoi1501 tách ra làm 2 dòng như này giúp anh nhé

#. module: account
#: model:ir.model.fields.selection,name:account.selection__account_payment__payment_type__outbound
msgid "Send"
msgstr "Chi tiền"

#. module: account
#: model_terms:ir.ui.view,arch_db:account.account_invoice_send_wizard_form
msgid "Send"
msgstr "Gửi"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@royleviindoo cái này em đã thử tách rồi ạ, nhưng khi chạy trên local thì báo lỗi ạ

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuoi1501 lỗi gì em?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuoi1501 lỗi gì em?

@royleviindoo Khi mà em cập nhật lại bản dịch thì hệ thống báo lỗi này ạ
image

@tranngocson1996
Copy link

@tuoi1501 em lấy code mới về rebase lại nhé

@tuoi1501
Copy link
Author

tuoi1501 commented Nov 3, 2022

@tuoi1501 em lấy code mới về rebase lại nhé

dạ vâng anh

@viinbot viinbot added 🚀 Queue 🚀 Running PR/Commit is done for everything and ready for manually test and removed 🚀 Running PR/Commit is done for everything and ready for manually test 🚀 Queue labels Nov 3, 2022
@viinbot viinbot added 🚀 Queue and removed 🚀 Running PR/Commit is done for everything and ready for manually test labels Nov 9, 2022
@tuoi1501 tuoi1501 force-pushed the v15_i18n_account branch 2 times, most recently from 122a486 to 8db323c Compare November 9, 2022 04:32
@viinbot viinbot added 🚀 Running PR/Commit is done for everything and ready for manually test 🚩 Done PR/Commit is finished manually test and closed instance and removed 🚩 Done PR/Commit is finished manually test and closed instance 🚀 Running PR/Commit is done for everything and ready for manually test labels Mar 31, 2023
@viinbot viinbot added 🚀 Queue and removed 🚩 Done PR/Commit is finished manually test and closed instance labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants