Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation #22

Merged
merged 2 commits into from
Dec 2, 2021
Merged

French translation #22

merged 2 commits into from
Dec 2, 2021

Conversation

melaniedrevet
Copy link
Contributor

@melaniedrevet melaniedrevet commented Dec 1, 2021

Issue #16

@VickiLanger
Copy link
Owner

Thank you so much for your work. I'm looking for another person to review before merging. Once they've reviewed, we shall merge your pr.

After that, I'll add a link to this version.

Copy link

@vanakenm vanakenm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks already for this content and the translation. The exercise was much more difficult than I though - great job there.

There is a lot of nuance involved, and some things do not translate that easily from a language to another. I put proposals where I felt I could propose an alternative, but those are just that - proposals.

Hope it helps.

site/checklist_fr.md Outdated Show resolved Hide resolved
site/checklist_fr.md Outdated Show resolved Hide resolved
site/checklist_fr.md Outdated Show resolved Hide resolved
site/checklist_fr.md Outdated Show resolved Hide resolved
site/checklist_fr.md Outdated Show resolved Hide resolved
site/checklist_fr.md Outdated Show resolved Hide resolved
site/checklist_fr.md Show resolved Hide resolved
site/checklist_fr.md Show resolved Hide resolved
site/checklist_fr.md Outdated Show resolved Hide resolved
site/checklist_fr.md Outdated Show resolved Hide resolved
@melaniedrevet
Copy link
Contributor Author

Hi ! Indeed, there are a lot of words that don't really have an exact translation in French, that's why sometimes I translated "word by word" even if that didn't make too much sense.

In any case, thank you for your suggestions, I changed all that!

@VickiLanger VickiLanger merged commit c6cb365 into VickiLanger:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants