fix: create a common chart per deployment if needed

actions/discover-run-plan/action.yaml

@@ -13,7 +13,7 @@ inputs:
     required: false
 runs:
   using: docker
-  image: docker://public.ecr.aws/vdb-public/gh-mpyl:v1.2.2
+  image: docker://public.ecr.aws/vdb-public/gh-mpyl:pr-191
   args:
     - plan
     - discover

actions/generate-kubernetes-manifests/action.yaml

@@ -29,7 +29,7 @@ inputs:
     required: false
 runs:
   using: docker
-  image: docker://public.ecr.aws/vdb-public/gh-mpyl:v1.2.2
+  image: docker://public.ecr.aws/vdb-public/gh-mpyl:pr-191
   args:
     - build
     - --environment

actions/health-check/action.yaml

@@ -7,7 +7,7 @@ inputs:
     required: false
 runs:
   using: docker
-  image: docker://public.ecr.aws/vdb-public/gh-mpyl:v1.2.2
+  image: docker://public.ecr.aws/vdb-public/gh-mpyl:pr-191
   args:
     - health
   env:

actions/lint-projects/action.yaml

@@ -7,7 +7,7 @@ inputs:
     required: false
 runs:
   using: docker
-  image: docker://public.ecr.aws/vdb-public/gh-mpyl:v1.2.2
+  image: docker://public.ecr.aws/vdb-public/gh-mpyl:pr-191
   args:
     - projects
     - lint

mpyl_config.example.yml

@@ -57,8 +57,6 @@ project:  # default values
   allowedMaintainers: [Team1, Team2, MPyL]
   deployment:
     kubernetes:
-      imagePullSecrets:
-        - name: acme-registry
       job:
         ttlSecondsAfterFinished:
           all: 3600

src/mpyl/project.py

@@ -316,7 +316,6 @@ class Kubernetes:
     metrics: Optional[Metrics]
     resources: Resources
     job: Optional[Job]
-    image_pull_secrets: dict
     role: Optional[dict]
     command: Optional[TargetProperty[str]]
     args: Optional[TargetProperty[str]]
@@ -332,7 +331,6 @@ def from_config(values: dict):
             metrics=Metrics.from_config(values.get("metrics", {})),
             resources=Resources.from_config(values.get("resources", {})),
             job=Job.from_config(values.get("job", {})),
-            image_pull_secrets=values.get("imagePullSecrets", {}),
             role=values.get("role"),
             command=TargetProperty.from_config(values.get("command", {})),
             args=TargetProperty.from_config(values.get("args", {})),
@@ -548,8 +546,8 @@ def project_overrides_yaml_file_pattern() -> str:
         return "project-override-*.yml"
 
     @staticmethod
-    def traefik_yaml_file_name(service_name: str) -> str:
-        return f"{service_name}-traefik.yml"
+    def traefik_yaml_file_name(deployment_name: str) -> str:
+        return f"{deployment_name}-traefik.yml"
 
     @property
     def root_path(self) -> Path:

src/mpyl/schema/project.schema.yml

@@ -759,12 +759,6 @@ definitions:
         additionalProperties: false
       portMappings:
         type: object
-      imagePullSecrets:
-        minItems: 1
-        description: 'ImagePullSecrets is a list of references to secrets in the same namespace to use for pulling any images in pods that reference this ServiceAccount. ImagePullSecrets are distinct from Secrets because Secrets can be mounted in the pod, but ImagePullSecrets are only accessed by the kubelet. More info: https://kubernetes.io/docs/concepts/containers/images/#specifying-imagepullsecrets-on-a-pod'
-        items:
-          $ref: k8s_api_core.schema.yml#/definitions/io.k8s.api.core.v1.LocalObjectReference
-        type: [array, null]
       job:
         type: object
         additionalProperties: true

src/mpyl/steps/deploy/k8s/__init__.py

@@ -62,18 +62,32 @@ def get_namespace_for_linked_project(project: Project) -> str:
             return f"pr-{pr_identifier}"
         return project.namespace(target)
 
-    def replace_namespace(env_value: str, project_name: str, namespace: str) -> str:
-        search_value = project_name + ".{namespace}"
-        replace_value = project_name + "." + namespace
-        return env_value.replace(search_value, replace_value)
+    def replace_namespace(
+        original_value: str,
+        service_name: str,
+        namespace: str,
+    ):
+        search_value = service_name + ".{namespace}"
+        replace_value = service_name + "." + namespace
+        replaced_namespace = original_value.replace(search_value, replace_value)
+        updated_pr = replace_pr_number(replaced_namespace, pr_identifier)
+        if updated_pr != original_value:
+            env[key] = updated_pr
 
     for project in all_projects:
         linked_project_namespace = get_namespace_for_linked_project(project)
         for key, value in env.items():
-            replaced_namespace = replace_namespace(
-                value, project.name, linked_project_namespace
+            replace_namespace(
+                original_value=value,
+                service_name=project.name,
+                namespace=linked_project_namespace,
             )
-            updated_pr = replace_pr_number(replaced_namespace, pr_identifier)
-            env[key] = updated_pr
+
+            for deployment in project.deployments:
+                replace_namespace(
+                    original_value=value,
+                    service_name=deployment.name,
+                    namespace=linked_project_namespace,
+                )
 
     return env