Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create a common chart per deployment if needed #191

Merged
merged 27 commits into from
Feb 28, 2025
Merged

fix: create a common chart per deployment if needed #191

merged 27 commits into from
Feb 28, 2025
+268 −215

Conversation

Jorg88
Copy link

@Jorg88 Jorg88 commented Feb 14, 2025 •
edited by ptab
Loading

Validated in:

Changes in this PR for a project without overrides: 👍

Changes in this PR for a project with overrides: 👍

Changes in this PR for a project with multiple deployments: 👍

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

Code Coverage

Package Line Rate Health
src.mpyl 85% ➖
src.mpyl.cli 63% ❌
src.mpyl.plan 100% ✔
src.mpyl.projects 73% ❌
src.mpyl.steps 92% ➖
src.mpyl.steps.deploy 80% ➖
src.mpyl.steps.deploy.k8s 95% ➖
src.mpyl.steps.deploy.k8s.resources 98% ➖
src.mpyl.utilities 92% ➖
src.mpyl.utilities.dagster 72% ❌
src.mpyl.utilities.docker 82% ➖
src.mpyl.utilities.helm 100% ✔
src.mpyl.utilities.http_client 85% ➖
src.mpyl.utilities.logging 78% ❌
src.mpyl.utilities.pyaml_env 100% ✔
src.mpyl.utilities.repo 97% ➖
src.mpyl.utilities.subprocess 76% ❌
src.mpyl.utilities.yaml 100% ✔
Summary 86% (1916 / 2235) ➖

Minimum allowed line rate is 79%

@Jorg88 Jorg88 changed the title fix: create a unique prometheus chart per deployment fix: create a common chart per deployment if needed Feb 14, 2025
Jorg88 added 11 commits February 19, 2025 13:59
@Jorg88
chore: remove imagePullSecrets and generate sealed secrets per deploy…
77b1ef6 
…ment
@Jorg88
Fix the sealed secrets unit tests
dc5d9a2
@Jorg88
Use pr version docker image for testing purposes
92cfc48
@Jorg88
Merge branch 'main' of github.com:Vandebron/gh-mpyl into feature/GUIL…
cdc997c 
…D-1220-fix-common-charts
@Jorg88
chore: add labels per deployment when needed
f43448a
@Jorg88
Fix the env var namespace replacement to account for multiple deploym…
f06dbbe 
…ents
@Jorg88
Merge branch 'main' of github.com:Vandebron/gh-mpyl into feature/GUIL…
be8093a 
…D-1220-fix-common-charts
@Jorg88
Only update the the env var if it's changed
f63e738
@Jorg88
Use the lower case deployment name for deployments, sealed secrets an…
b7ec2d0 
…d prometheus rules
@Jorg88
Also lower case the service name
9f7e26c
@Jorg88
Also change the name of the sealed secrets key ref
e3ef2c4
@Jorg88 Jorg88 force-pushed the feature/GUILD-1220-fix-common-charts branch from 00b0ec9 to e3ef2c4 Compare February 20, 2025 08:45
@Jorg88 Jorg88 marked this pull request as ready for review February 23, 2025 09:19
@Jorg88 Jorg88 requested a review from a team as a code owner February 23, 2025 09:19
@Jorg88 Jorg88 requested review from jjbavdb and ptab February 23, 2025 09:19
@Jorg88 Jorg88 force-pushed the feature/GUILD-1220-fix-common-charts branch from 5252e63 to 4d1b820 Compare February 26, 2025 14:41
@ptab ptab merged commit ff390b2 into main Feb 28, 2025
8 of 9 checks passed
@ptab ptab deleted the feature/GUILD-1220-fix-common-charts branch February 28, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptab ptab ptab approved these changes

@jjbavdb jjbavdb Awaiting requested review from jjbavdb jjbavdb is a code owner automatically assigned from Vandebron/guild-ci-cd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jorg88 @ptab