-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prefix to wrench hw interface #217
Add prefix to wrench hw interface #217
Conversation
Update our master
…_Robots_ROS_Driver into add_prefix_to_wrench_hw_interface
I think, it would be better to either use the |
|
Do you think, it would make sense to read it from the root node handle, similar to joint_names, then we could configure this together with instanciating the controller in https://github.com/UniversalRobots/Universal_Robots_ROS_Driver/blob/master/ur_robot_driver/config/ur10_controllers.yaml#L21 In my opinion that would be preferable over introducing yet another launch file parameter. |
Also, once everything is in place, we should make sure that documentation is everywhere at the right places, e.g. here |
I think that would cause us a similar problem to the one we have here: #110 |
This doesn't appear to be setting a prefix any more, but it configures the actual Suggestion: use |
That's nicer, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Adds a prefix to the wrench hw interface so that multiple arms can have their force torque sensors used at the same time