Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PPV2] PPB-29 Fixed grid gizmo is visible through geometry when Post Process Layer is enabled #7993

Merged
merged 5 commits into from
Nov 14, 2023
Merged

[PPV2] PPB-29 Fixed grid gizmo is visible through geometry when Post Process Layer is enabled #7993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c253cc4
Remove ImageEffectUsesCommandBuffer attribute
BenGraterUnity Nov 7, 2023
17236e0
Update changelog
BenGraterUnity Nov 8, 2023
62ec4b7
Merge branch 'master' into ppv2/ppb-29
BenGraterUnity Nov 10, 2023
e1c25f3
Only disable ImageEffectUsesCommandBuffer in editor
BenGraterUnity Nov 14, 2023
0cef299
Update OSX reference images
BenGraterUnity Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...Tests/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/0207_Std_Bloom_HDR.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions .../Assets/ReferenceImages/Linear/OSXEditor/Metal/None/0208_Std_Bloom_HDR_Fast.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ..._Tests/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/0211_Std_LensDirt.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 3 additions & 2 deletions com.unity.postprocessing/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@ All notable changes to this package will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [3.3.1] - 2023-06-02
## [3.3.1] - 2023-00-00

### Fixed
- Fixed obsolete FormatUsage bug
- Disabled compute based effects not supported on WebGL and Android OpenGL
- Disabled compute based effects not supported on WebGL and Android OpenGL (IN-2999)
- Fixed grid gizmo is visible through geometry when Post Process Layer is enabled (IN-10318)

## [3.3.0] - 2023-05-11

Expand Down
2 changes: 2 additions & 0 deletions com.unity.postprocessing/PostProcessing/Runtime/PostProcessLayer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,9 @@ bool DynamicResolutionAllowsFinalBlitToCameraTarget()
#if UNITY_2019_1_OR_NEWER
// We always use a CommandBuffer to blit to the final render target
// OnRenderImage is used only to avoid the automatic blit from the RenderTexture of Camera.forceIntoRenderTexture to the actual target
#if !UNITY_EDITOR
[ImageEffectUsesCommandBuffer]
#endif
void OnRenderImage(RenderTexture src, RenderTexture dst)
{
if (finalBlitToCameraTarget && !m_CurrentContext.stereoActive && DynamicResolutionAllowsFinalBlitToCameraTarget())
Expand Down