[PPV2] PPB-29 Fixed grid gizmo is visible through geometry when Post Process Layer is enabled #7993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenGraterUnity
requested review from
Chman,
UnityBartPieters,
sebastienlagarde and
maloyer-unity
Chman
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix for PPB-29 by removing the
[ImageEffectUsesCommandBuffer]attribute fromOnRenderImage()when in editor.Testing status
Manually confirmed fix on Unity 2023.3.0a14 (Windows)
Manually ran Graphics tests in Unity 2023.3.0a14 (Windows)
Automated tests: