-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new caching route lambda for async routing invocation #887
Conversation
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
e9e4a59
to
0619f26
Compare
7aa13c4
to
230ba54
Compare
Graphite Automations"Request reviewers once CI passes on routing-api repo" took an action on this PR • (10/28/24)4 reviewers were added and 1 assignee was added to this PR based on 's automation. |
162119e
to
4d9a6e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a test to confirm that the right lambda is invoked, otherwise we are good
4d9a6e2
to
804d9d3
Compare
that's a good starting point - i was thinking if it's possible/easy for the caching lambda to only execute logic related to cache update, instead of the entire handler code. We can discuss offline. |
yea lets discuss offline, im also thinking about how to write a test that can assert it invokes the caching lambda |
we want to try creating a new caching routing lambda for async lambda invocation, that will not get exposed through the api gateway. this separates the live path from the async path through two different routing lambdas.
On my local routing dashboard, I tuned all cached routes rollout percent to 100%. I can see the caching intent charts are still there:
I also added a test to assert against the spied metric that hits the new caching routing lambda