fix cdk construct

Uniswap · Oct 28, 2024 · 230ba54 · 230ba54
1 parent aa4acaf
commit 230ba54
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 13 deletions.
diff --git a/bin/stacks/routing-lambda-stack.ts b/bin/stacks/routing-lambda-stack.ts
@@ -223,7 +223,7 @@ export class RoutingLambdaStack extends cdk.NestedStack {
       layers: [
         aws_lambda.LayerVersion.fromLayerVersionArn(
           this,
-          'InsightsLayer',
+          'CachingInsightsLayer',
           `arn:aws:lambda:${region}:580247275435:layer:LambdaInsightsExtension:14`
         ),
       ],
@@ -248,7 +248,7 @@ export class RoutingLambdaStack extends cdk.NestedStack {
       threshold: 0.05,
       evaluationPeriods: 3,
     })
-    const lambdaAlarmErrorRate = new aws_cloudwatch.Alarm(this, 'RoutingAPI-LambdaErrorRate', {
+    const lambdaAlarmErrorRate = new aws_cloudwatch.Alarm(this, 'CachingRoutingAPI-LambdaErrorRate', {
       metric: new aws_cloudwatch.MathExpression({
         expression: 'errors / invocations',
         usingMetrics: {
@@ -266,7 +266,7 @@ export class RoutingLambdaStack extends cdk.NestedStack {
       evaluationPeriods: 3,
     })
 
-    const cachingLambdaThrottlesErrorRate = new aws_cloudwatch.Alarm(this, 'RoutingAPI-LambdaThrottles', {
+    const cachingLambdaThrottlesErrorRate = new aws_cloudwatch.Alarm(this, 'CachingRoutingAPI-LambdaThrottles', {
       metric: cachingRoutingLambda.metricThrottles({
         period: Duration.minutes(5),
         statistic: 'sum',

diff --git a/lib/handlers/injector-sor.ts b/lib/handlers/injector-sor.ts
@@ -473,7 +473,7 @@ export abstract class InjectorSOR<Router, QueryParams> extends Injector<
           let routeCachingProvider: IRouteCachingProvider | undefined = undefined
 
           if (Math.random() * 100 < (newCachedRoutesRolloutPercent ?? 0)) {
-            if (CACHED_ROUTES_TABLE_NAME && CACHED_ROUTES_TABLE_NAME !== '' && CACHING_ROUTING_LAMBDA_FUNCTION_NAME) {
+            if (CACHED_ROUTES_TABLE_NAME && CACHED_ROUTES_TABLE_NAME !== '') {
               routeCachingProvider = new DynamoRouteCachingProvider({
                 routesTableName: ROUTES_TABLE_NAME!,
                 routesCachingRequestFlagTableName: ROUTES_CACHING_REQUEST_FLAG_TABLE_NAME!,

diff --git a/lib/handlers/router-entities/route-caching/dynamo-route-caching-provider.ts b/lib/handlers/router-entities/route-caching/dynamo-route-caching-provider.ts
@@ -31,15 +31,15 @@ interface ConstructorParams {
   /**
    * The Lambda Function Name for the Lambda that will be invoked to fill the cache
    */
-  cachingQuoteLambdaName: string
+  cachingQuoteLambdaName?: string
 }
 
 export class DynamoRouteCachingProvider extends IRouteCachingProvider {
   private readonly ddbClient: DynamoDB.DocumentClient
   private readonly lambdaClient: Lambda
   private readonly routesTableName: string
   private readonly routesCachingRequestFlagTableName: string
-  private readonly cachingQuoteLambdaName: string
+  private readonly cachingQuoteLambdaName?: string
 
   private readonly DEFAULT_CACHEMODE_ROUTES_DB = CacheMode.Livemode
   private readonly ROUTES_DB_TTL = 24 * 60 * 60 // 24 hours
@@ -312,15 +312,17 @@ export class DynamoRouteCachingProvider extends IRouteCachingProvider {
       },
     }
 
-    const params = {
-      FunctionName: this.cachingQuoteLambdaName,
-      InvocationType: 'Event',
-      Payload: JSON.stringify(payload),
-    }
+    if (this.cachingQuoteLambdaName) {
+      const params = {
+        FunctionName: this.cachingQuoteLambdaName,
+        InvocationType: 'Event',
+        Payload: JSON.stringify(payload),
+      }
 
-    log.info(`[DynamoRouteCachingProvider] Sending async caching request to lambda ${JSON.stringify(params)}`)
+      log.info(`[DynamoRouteCachingProvider] Sending async caching request to lambda ${JSON.stringify(params)}`)
 
-    this.lambdaClient.invoke(params).promise()
+      this.lambdaClient.invoke(params).promise()
+    }
   }
 
   private setRoutesDbCachingIntentFlag(