cleanup GetPlayerLightColor vs GetPlayerLightColorV2 #892
+1
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o fixes a long-standing bug where if P1 or P2 in duets had picked one of the later colors, their lyrics would be colored blue instead of their own color
barbeque-squared
force-pushed
the
remove-useless-color-function
branch
from
581b6c7
to
d526a60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some cleanup around GetPlayerLightColor vs GetPlayerLightColorV2.
also fixes a long-standing bug where if P1 or P2 in duets had picked one of the later colors (for example Flame), their lyrics would be colored blue instead of their own color. It now picks the correct color.