Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

102 test modify student #104

Merged
merged 6 commits into from
Nov 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ protected SecurityFilterChain securityFilterChain(HttpSecurity http) throws Exce
.requestMatchers(HttpMethod.POST, "/properties").hasAuthority("ROLE_OWNER")
.requestMatchers(HttpMethod.PUT, "/properties/*").hasAuthority("ROLE_OWNER")
.requestMatchers(HttpMethod.DELETE, "/properties/*").hasAuthority("ROLE_OWNER")
.requestMatchers(HttpMethod.POST, "/students").permitAll()
.requestMatchers(HttpMethod.PUT, "/students/*").hasAuthority("ROLE_STUDENT")
.requestMatchers(HttpMethod.DELETE, "/students/*").hasAuthority("ROLE_STUDENT")
.requestMatchers(HttpMethod.POST, "/visits").authenticated()
.requestMatchers(HttpMethod.DELETE, "/visits/*").authenticated()
.requestMatchers(HttpMethod.POST, "/*/*").authenticated()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
package cat.udl.eps.softarch.demo.repository;

import cat.udl.eps.softarch.demo.domain.Property;
import cat.udl.eps.softarch.demo.domain.Student;
import org.springframework.data.repository.CrudRepository;
import org.springframework.data.repository.query.Param;

public interface StudentRepository extends CrudRepository<Student, Long> {
import java.util.List;

public interface StudentRepository extends CrudRepository<Student, String> {
Student findByEmail(@Param("email") String email);
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
package cat.udl.eps.softarch.demo.steps;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
import static org.springframework.test.web.servlet.result.MockMvcResultHandlers.print;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;

import cat.udl.eps.softarch.demo.domain.Student;
import cat.udl.eps.softarch.demo.repository.StudentRepository;
import io.cucumber.java.en.And;
import io.cucumber.java.en.When;
import org.json.JSONObject;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.http.MediaType;
import org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder;
import org.springframework.security.crypto.password.PasswordEncoder;

import java.nio.charset.StandardCharsets;

public class CreateStudentStepDefs {
@Autowired
private StepDefs stepDefs;

@Autowired
private StudentRepository studentRepository;

@When("^I create a student with username \"([^\"]*)\" and password \"([^\"]*)\" and email \"([^\"]*)\" and phoneNumber \"([^\"]*)\" and name \"([^\"]*)\"$")
public void createStudent(String username, String password, String email, String phoneNumber, String name) throws Throwable {
Student studentTest = new Student();

studentTest.setUsername(assignValueInput(username));
studentTest.setEmail(assignValueInput(email));
studentTest.setPhoneNumber(assignValueInput(phoneNumber));
studentTest.setName(assignValueInput(name));



stepDefs.result = stepDefs.mockMvc.perform(
post("/students")
.contentType(MediaType.APPLICATION_JSON)
.content(new JSONObject(
stepDefs.mapper.writeValueAsString(studentTest)
).put("password", assignValueInput(password)).toString())
.characterEncoding(StandardCharsets.UTF_8))
.andDo(print());

}

private String assignValueInput(String value) {
if(value.equals("null")){
return null;
}
else {
return value;
}
}

@And("^There is 0 Student created$")
public void thereIs0StudentCreated() throws Throwable {
assertEquals(studentRepository.count(), 0);
}

@And("^There is 1 Student created with username \"([^\"]*)\" and email \"([^\"]*)\" and phoneNumber \"([^\"]*)\" and name \"([^\"]*)\"$")
public void thereIs1StudentCreated(String username, String email, String phoneNumber, String name) throws Throwable {
assertEquals(studentRepository.count(), 1);
Student studentToCheck = this.studentRepository.findByEmail(email);
assertEquals(studentToCheck.getUsername(), username);
assertEquals(studentToCheck.getName(), name);
assertEquals(studentToCheck.getPhoneNumber(), phoneNumber);
assertEquals(studentToCheck.getEmail(), email);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
package cat.udl.eps.softarch.demo.steps;

import cat.udl.eps.softarch.demo.domain.Property;
import cat.udl.eps.softarch.demo.domain.Student;
import cat.udl.eps.softarch.demo.repository.StudentRepository;
import com.fasterxml.jackson.core.JsonProcessingException;
import io.cucumber.java.en.Given;
import io.cucumber.java.en.When;
import org.json.JSONException;
import org.json.JSONObject;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.http.MediaType;

import java.nio.charset.StandardCharsets;

import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.put;
import static org.springframework.test.web.servlet.result.MockMvcResultHandlers.print;

public class ModifyStudentStepDefs {

@Autowired
StepDefs stepDefs;

@Autowired
StudentRepository studentRepository;

Student student;


@Given("There is a registered student with username {string} and password {string} and email {string} and phoneNumber {string} and name {string}")
public void there_is_a_student_already_created_with_values(String username, String password, String email, String phoneNumber, String name) {
this.student = new Student();
student.setUsername(username);
student.setPassword(password);
student.encodePassword();
student.setEmail(email);
student.setPhoneNumber(phoneNumber);
student.setName(name);


this.studentRepository.save(student);
}



@When("I modify student {string} with username {string} and password {string} and email {string} and phoneNumber {string} and name {string}")
public void modify_a_student_with_values(String studentEmail, String username, String password, String email, String phoneNumber, String name) throws Throwable {
Student studentTest = studentRepository.findByEmail(studentEmail);
String id = studentTest.getId();


studentTest.setEmail(assignValueInput(email));
studentTest.setPhoneNumber(assignValueInput(phoneNumber));
studentTest.setName(assignValueInput(name));
stepDefs.result = this.stepDefs.mockMvc.perform(
put("/students/"+id)
.contentType(MediaType.APPLICATION_JSON)
.content(new JSONObject(
stepDefs.mapper.writeValueAsString(studentTest)
).put("password", assignValueInput(password)).toString())
.characterEncoding(StandardCharsets.UTF_8)
.with(AuthenticationStepDefs.authenticate()))
.andDo(print());
}


private String assignValueInput(String value) {
if(value.equals("null")){
return null;
}
else {
return value;
}
}

}
72 changes: 72 additions & 0 deletions src/test/resources/features/CreateStudent.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
Feature: Create Student
In order to look for properties as an student
I want to create an student profile


Scenario: Create a Student with valid data
Given I'm not logged in
When I create a student with username "student" and password "password" and email "[email protected]" and phoneNumber "123123123" and name "Student"
Then The response code is 201
And There is 1 Student created with username "student" and email "[email protected]" and phoneNumber "123123123" and name "Student"


Scenario: Create a student with a blank email:
Given I'm not logged in
When I create a student with username "student" and password "password" and email "" and phoneNumber "123123123" and name "Student"
Then The response code is 400
And There is 0 Student created

Scenario: Create a student with a blank password:
Given I'm not logged in
When I create a student with username "student" and password "" and email "[email protected]" and phoneNumber "123123123" and name "Student"
Then The response code is 400
And There is 0 Student created

Scenario: Create a student with an empty phoneNumber:
Given I'm not logged in
When I create a student with username "student" and password "password" and email "[email protected]" and phoneNumber "" and name "Student"
Then The response code is 400
And There is 0 Student created

Scenario: Create a student with an empty name:
Given I'm not logged in
When I create a student with username "student" and password "password" and email "[email protected]" and phoneNumber "123123123" and name ""
Then The response code is 400
And There is 0 Student created

Scenario: Create a student with an empty username:
Given I'm not logged in
When I create a student with username "" and password "password" and email "[email protected]" and phoneNumber "123123123" and name ""
Then The response code is 400
And There is 0 Student created

Scenario: Create a student with a null email:
Given I'm not logged in
When I create a student with username "student" and password "password" and email "null" and phoneNumber "123123123" and name "Student"
Then The response code is 400
And There is 0 Student created

Scenario: Create a student with a null password:
Given I'm not logged in
When I create a student with username "student" and password "null" and email "[email protected]" and phoneNumber "123123123" and name "Student"
Then The response code is 400
And There is 0 Student created

Scenario: Create a student with an null phoneNumber:
Given I'm not logged in
When I create a student with username "student" and password "password" and email "[email protected]" and phoneNumber "null" and name "Student"
Then The response code is 400
And There is 0 Student created

Scenario: Create a student with an null name:
Given I'm not logged in
When I create a student with username "student" and password "password" and email "[email protected]" and phoneNumber "123123123" and name "null"
Then The response code is 400
And There is 0 Student created


Scenario: Create a student with a null username:
Given I'm not logged in
When I create a student with username "null" and password "password" and email "[email protected]" and phoneNumber "123123123" and name ""
Then The response code is 400
And There is 0 Student created
71 changes: 71 additions & 0 deletions src/test/resources/features/ModifyStudent.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
Feature: Modify Student

In order to make changes on a student
As a student
I want to modify a student

Background:
Given There is a registered student with username "student" and password "password" and email "[email protected]" and phoneNumber "123123123" and name "Student"

Scenario: Modify a Student when not logged in
Given I'm not logged in
When I modify student "[email protected]" with username "student" and password "password" and email "[email protected]" and phoneNumber "123123123" and name "Student"
Then The response code is 401
And The error message is "Unauthorized"
And There is 1 Student created with username "student" and email "[email protected]" and phoneNumber "123123123" and name "Student"


Scenario: Modify a Student with valid data
Given I login as "student" with password "password"
When I modify student "[email protected]" with username "student" and password "passwordModified" and email "[email protected]" and phoneNumber "111222333" and name "StudentModified"
Then The response code is 204
And There is 1 Student created with username "student" and email "[email protected]" and phoneNumber "111222333" and name "StudentModified"


Scenario: Modify a student with a blank email:
Given I login as "student" with password "password"
When I modify student "[email protected]" with username "student" and password "password" and email "" and phoneNumber "123123123" and name "Student"
Then The response code is 400
And There is 1 Student created with username "student" and email "[email protected]" and phoneNumber "123123123" and name "Student"

Scenario: Modify a student with a blank password:
Given I login as "student" with password "password"
When I modify student "[email protected]" with username "student" and password "" and email "[email protected]" and phoneNumber "123123123" and name "Student"
Then The response code is 400
And There is 1 Student created with username "student" and email "[email protected]" and phoneNumber "123123123" and name "Student"

Scenario: Modify a student with an empty phoneNumber:
Given I login as "student" with password "password"
When I modify student "[email protected]" with username "student" and password "passwordModified" and email "[email protected]" and phoneNumber "" and name "StudentModified"
Then The response code is 400
And There is 1 Student created with username "student" and email "[email protected]" and phoneNumber "123123123" and name "Student"

Scenario: Modify a student with an empty name:
Given I login as "student" with password "password"
When I modify student "[email protected]" with username "student" and password "password" and email "[email protected]" and phoneNumber "123123123" and name ""
Then The response code is 400
And There is 1 Student created with username "student" and email "[email protected]" and phoneNumber "123123123" and name "Student"

Scenario: Modify a student with a null email:
Given I login as "student" with password "password"
When I modify student "[email protected]" with username "student" and password "passwordModified" and email "null" and phoneNumber "111222333" and name "StudentModified"
Then The response code is 400
And There is 1 Student created with username "student" and email "[email protected]" and phoneNumber "123123123" and name "Student"

Scenario: Modify a student with a null password:
Given I login as "student" with password "password"
When I modify student "[email protected]" with username "student" and password "null" and email "[email protected]" and phoneNumber "123123123" and name "Student"
Then The response code is 400
And There is 1 Student created with username "student" and email "[email protected]" and phoneNumber "123123123" and name "Student"

Scenario: Modify a student with an null phoneNumber:
Given I login as "student" with password "password"
When I modify student "[email protected]" with username "student" and password "password" and email "[email protected]" and phoneNumber "null" and name "Student"
Then The response code is 400
And There is 1 Student created with username "student" and email "[email protected]" and phoneNumber "123123123" and name "Student"

Scenario: Modify a student with an null name:
Given I login as "student" with password "password"
When I modify student "[email protected]" with username "student" and password "password" and email "[email protected]" and phoneNumber "123123123" and name "null"
Then The response code is 400
And There is 1 Student created with username "student" and email "[email protected]" and phoneNumber "123123123" and name "Student"
Loading